Credential plugins: lookup command relative to config's dir, nil = opt-out #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t out Matches Go client's behavior: kubernetes/kubernetes#59495 (comment) Distinguish 3 cases: - absolute (e.g. /path/to/foo) - $PATH-based (e.g. curl) - relative to config file's dir (e.g. ./foo) If base dir explicitly set to nil, refuse to execute external commands, matching existing opt-out from file lookups (ManageIQ#372). Document security aspects of credential plugins.
|
@motymichaely @KnVerey @rhodrid @f4tq please review. |
|
@motymichaely @KnVerey @rhodrid @f4tq @jeremywadsack @fw42 @yaacov @grosser looking for at least one review. |
motymichaely
approved these changes
Dec 20, 2018
Merged
|
@cben Looks good. I'll be excited when GCP moves this this instead of the customer provider. |
|
Released 4.2.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #363.
Refine lookup to match Go client's behavior: Distinguish 3 cases:
/path/to/foo)$PATH-based (e.g.curl)./foo)If base dir explicitly set to nil, refuse to execute external commands, matching existing opt-out from file lookups (#372).
Document security aspects of credential plugins.
EDIT: ref https://banzaicloud.com/blog/kubeconfig-security/, kubernetes/kubectl#697