use forking-test-runner to ensure no test pollution between different… #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grosser
force-pushed
the
grosser/fork
branch
from
fa61514
to
3bab608
Compare
|
welp ... truffle-ruby does not have fork 😞 |
grosser
force-pushed
the
grosser/fork
branch
from
3bab608
to
193179b
Compare
|
fixed that ... still errors seems to be 98 and 135 mostly :/ |
grosser
force-pushed
the
grosser/fork
branch
7 times, most recently
from
355adae
to
193179b
Compare
|
fixed the errors in #594 ... this PR needs a rebase once that's merged |
|
All green now with #594. You still consider this desired, right? Oh, it's your gem. Looks very nice! 👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… test files
maybe this cuts down on the random errors
... and even if not it should reduce wild goose chases if one test messes with global state