Use lsblk to detect local disks #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will remove the need to track all the different disk naming schemes using a regex. Specifically it will allow us to find nvme devices which are used in some AWS instance types https://bugzilla.redhat.com/show_bug.cgi?id=1629853
carbonin
force-pushed
the
use_lsblk_for_disk_detection
branch
from
b7d42b7
to
eaff9fc
Compare
|
Checked commit carbonin@eaff9fc with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will remove the need to track all the different disk
naming schemes using a regex.
Specifically it will allow us to find nvme devices which are used
in some AWS instance types
https://bugzilla.redhat.com/show_bug.cgi?id=1629853