Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add delete and update to host initiator groups #1201

Merged
merged 3 commits into from Mar 1, 2023
Merged

add delete and update to host initiator groups #1201

merged 3 commits into from Mar 1, 2023

Conversation

Lauferin
Copy link
Contributor

@Lauferin Lauferin changed the title Adrian/740029 add delete and update to host initiator groups [wip] Adrian/740029 add delete and update to host initiator groups Feb 13, 2023
@Lauferin Lauferin mentioned this pull request Feb 13, 2023
Closed
@miq-bot miq-bot added the wip label Feb 13, 2023
@Lauferin Lauferin force-pushed the adrian/740029-add_delete_and_update_to_host_initiator_groups branch 2 times, most recently from 34b75cb to 7ebae80 Compare February 15, 2023 07:20
@Lauferin Lauferin changed the title [wip] Adrian/740029 add delete and update to host initiator groups Adrian/740029 add delete and update to host initiator groups Feb 27, 2023
@miq-bot miq-bot removed the wip label Feb 27, 2023
@agrare
Copy link
Member

agrare commented Feb 27, 2023

@Lauferin the spec failures appear to be related to your changes

@Lauferin Lauferin force-pushed the adrian/740029-add_delete_and_update_to_host_initiator_groups branch from 7ebae80 to 5d9f766 Compare February 28, 2023 08:05
@Lauferin
Copy link
Contributor Author

Lauferin commented Feb 28, 2023 •
edited

@Lauferin the spec failures appear to be related to your changes

I've fixed one of the problems. The other two don't seem to be related to my changes, and they're not appearing in this page anymore (although I did get an email about them).
(actually I've deleted the email and now I'm doubting that the email might have been from yesterday).

@agrare
Copy link
Member

agrare commented Feb 28, 2023

The cloud volume spec failure should be fixed by #1208 I'll kick this after that gets merged

@agrare agrare closed this Feb 28, 2023
@agrare agrare reopened this Feb 28, 2023
@agrare
Copy link
Member

agrare commented Feb 28, 2023

@Lauferin okay we're back to just a HostInitiator spec failing

@Lauferin Lauferin force-pushed the adrian/740029-add_delete_and_update_to_host_initiator_groups branch from 5d9f766 to 11fca08 Compare March 1, 2023 08:03
@miq-bot
Copy link
Member

miq-bot commented Mar 1, 2023

Checked commits Autosde/manageiq-api@ecdd5fb~...11fca08 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint
2 files checked, 0 offenses detected
Everything looks fine. 🏆

@Lauferin
Copy link
Contributor Author

Lauferin commented Mar 1, 2023

@Lauferin okay we're back to just a HostInitiator spec failing

I changed something there but I don't know if it's working now because I'm again receiving failures from cloud_volume and something else.

@agrare agrare self-assigned this Mar 1, 2023
@agrare agrare merged commit 8b4513f into ManageIQ:master Mar 1, 2023
@Fryguy Fryguy changed the title Adrian/740029 add delete and update to host initiator groups add delete and update to host initiator groups Sep 14, 2023
@Fryguy Fryguy added this to the Petrosian milestone Sep 14, 2023
@Fryguy Fryguy added this to Petrosian in Roadmap Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdunne bdunne Awaiting requested review from bdunne bdunne is a code owner

Assignees

@agrare agrare

Labels
enhancement
Projects
Roadmap
  
Petrosian
Milestone
Petrosian
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Lauferin @agrare @miq-bot @Fryguy @eilam20