Specify a target and resource action when retrieving a service dialog #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fetching the content from a resource sometimes requires both a target and resource_action, where we are currently passing in nil values. By accepting resource_action_id, target_type, and target_id, we are able to use resource search to pass in the applicable values. https://bugzilla.redhat.com/show_bug.cgi?id=1518390
|
Checked commit jntullo@b100aa7 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 app/controllers/api/service_dialogs_controller.rb
|
simaishi
pushed a commit
that referenced
this pull request
Dec 4, 2017
Specify a target and resource action when retrieving a service dialog (cherry picked from commit a70e73d)
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fetching the content from a resource sometimes requires both a target and resource_action (ie for custom buttons), where we are currently passing in nil values. By accepting resource_action_id, target_type, and target_id, we are able to use resource search to pass in the applicable values.
Please verify @eclarizio
@miq-bot add_label bug, blocker
@miq-bot add_label gaprindashvili/yes
https://bugzilla.redhat.com/show_bug.cgi?id=1518390