Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix specifying of additional attributes on pictures #327

Merged
merged 1 commit into from Feb 27, 2018

Conversation

jntullo
Copy link

@jntullo jntullo commented Feb 22, 2018

Encoding errors strike again!

Requesting any additional attributes for a picture results in:

error:
{
    "error": {
        "kind": "internal_server_error",
        "message": "\"\\x89\" from ASCII-8BIT to UTF-8",
        "klass": "Encoding::UndefinedConversionError"
    }
}

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1547852

@abellotti
Copy link
Member

somehow with this PR, asking for an attribute I get them all, i.e. GET /api/pictures/2?attributes=extension, I get them all instead of just id/href/extension as we do with master.

@jntullo jntullo force-pushed the bz_1547852 branch 2 times, most recently from f5351b7 to 97612b5 Compare February 22, 2018 17:08
@abellotti
Copy link
Member

now I see all attributes with GET /api/pictures without attributes specified instead of just the href.

@jntullo jntullo force-pushed the bz_1547852 branch 3 times, most recently from f7f4580 to eb23df3 Compare February 26, 2018 13:07
@miq-bot
Copy link
Member

miq-bot commented Feb 27, 2018

Checked commit jntullo@2ae5d78 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
3 files checked, 0 offenses detected
Everything looks fine. 🍰

@abellotti
Copy link
Member

LGTM!! Thanks @jntullo for updating/fixing this. 👍

@abellotti abellotti merged commit a8d5c3a into ManageIQ:master Feb 27, 2018
@abellotti abellotti added this to the Sprint 80 Ending Feb 26, 2018 milestone Feb 27, 2018
simaishi pushed a commit that referenced this pull request Mar 7, 2018
Fix specifying of additional attributes on pictures
(cherry picked from commit a8d5c3a)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1552828
@simaishi
Copy link
Contributor

simaishi commented Mar 7, 2018

Gaprindashvili backport details:

$ git log -1
commit 7fb24195cffa6da14b0b980bac87747a4e5c0d0c
Author: Alberto Bellotti <abellotti@users.noreply.github.com>
Date:   Tue Feb 27 10:26:39 2018 -0500

    Merge pull request #327 from jntullo/bz_1547852
    
    Fix specifying of additional attributes on pictures
    (cherry picked from commit a8d5c3ac6ae862000a4b71b0517dd85275beb326)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1552828

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants