Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise bad request when current_group is specified on edit #329

Merged
merged 1 commit into from
Feb 27, 2018

Conversation

jntullo
Copy link

@jntullo jntullo commented Feb 27, 2018

Editing of a current_group is allowed only on on the set_current_group action.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1549086

Editing of a current_group is allowed only on on the set_current_group action.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1549086
@miq-bot
Copy link
Member

miq-bot commented Feb 27, 2018

Checked commit jntullo@d2e8ea4 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 🍰

@abellotti
Copy link
Member

LGTM !! we don't allow current_group_id, so this is the reference signature equivalent. 👍

@abellotti abellotti added this to the Sprint 80 Ending Feb 26, 2018 milestone Feb 27, 2018
@abellotti abellotti merged commit 40cf625 into ManageIQ:master Feb 27, 2018
@simaishi
Copy link
Contributor

simaishi commented Mar 5, 2018

Fine backport (to manageiq repo) details:

$ git log -1
commit 8460d9b01422a1cbed0b933a1f1da76fbfb9731c
Author: Alberto Bellotti <abellotti@users.noreply.github.com>
Date:   Tue Feb 27 09:29:01 2018 -0500

    Merge pull request #329 from jntullo/bz_1549086
    
    Raise bad request when current_group is specified on edit
    (cherry picked from commit 40cf625ebcbf56b9df316196463bbc6c011aaf92)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1551693

@simaishi
Copy link
Contributor

simaishi commented Mar 6, 2018

@jntullo Travis is failing in Fine branch, can you please address?

1) users API users edit does not allow edits of current_user
     Failure/Error: "href"          => api_user_url(nil, user1),
     NoMethodError:
       undefined method `api_user_url' for #<RSpec::ExampleGroups::UsersAPI::UsersEdit:0x000000313317c0>
     # /home/travis/.rvm/gems/ruby-2.3.1/gems/actionpack-5.0.6/lib/action_dispatch/testing/assertions/routing.rb:175:in `method_missing'
     # /home/travis/.rvm/gems/ruby-2.3.1/gems/actionpack-5.0.6/lib/action_dispatch/testing/integration.rb:491:in `method_missing'
     # ./spec/requests/api/users_spec.rb:196:in `block (3 levels) in <top (required)>'

@jntullo
Copy link
Author

jntullo commented Mar 6, 2018

@simaishi would you like me to create a fine-specific PR for this entire backport? or should I just create a fine-specific PR to fix just this failure? (it's a small fix)

@simaishi
Copy link
Contributor

simaishi commented Mar 6, 2018

Since this PR is already backported to Fine branch, please create a PR just to fix the failure. Thank you!

simaishi pushed a commit that referenced this pull request Mar 7, 2018
Raise bad request when current_group is specified on edit
(cherry picked from commit 40cf625)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1551692
@simaishi
Copy link
Contributor

simaishi commented Mar 7, 2018

Gaprindashvili backport details:

$ git log -1
commit 7f0cf0fbb32b5aef2ac8c41ab54082767f373344
Author: Alberto Bellotti <abellotti@users.noreply.github.com>
Date:   Tue Feb 27 09:29:01 2018 -0500

    Merge pull request #329 from jntullo/bz_1549086
    
    Raise bad request when current_group is specified on edit
    (cherry picked from commit 40cf625ebcbf56b9df316196463bbc6c011aaf92)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1551692

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants