Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass changed dialog field values to resource_action_workflow #448

Merged
merged 1 commit into from Sep 12, 2018

Conversation

d-m-u
Copy link
Contributor

@d-m-u d-m-u commented Aug 13, 2018

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1594469

I think that the api needs to be passing the changed dialog field values into the resource action workflow when we make the submit workflow call. Otherwise the field values automate sees by the time we get to https://github.com/ManageIQ/manageiq/blob/master/app/models/resource_action_workflow.rb#L81 will be the default values only, not the updated fields you changed on the dialog.

The setup this applies to is a custom button on a generic object.

Depends on:

ManageIQ/manageiq#17855
ManageIQ/manageiq#17973

@d-m-u
Copy link
Contributor Author

d-m-u commented Aug 13, 2018

@miq-bot add_label bug, blocker, gaprindashvili/yes
@miq-bot add_reviewer @eclarizio

@miq-bot
Copy link
Member

miq-bot commented Aug 13, 2018

Checked commit d-m-u@26bde70 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. ⭐

Copy link
Member

@eclarizio eclarizio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change itself looks ok, but the specs appear to be breaking because we need to have the method signature change from ManageIQ/manageiq#17855 implemented first.

@d-m-u d-m-u changed the title [WIP] Pass changed dialog field values to resource_action_workflow Pass changed dialog field values to resource_action_workflow Aug 14, 2018
@d-m-u
Copy link
Contributor Author

d-m-u commented Aug 14, 2018

@miq-bot remove_label wip

@miq-bot miq-bot removed the wip label Aug 14, 2018
@d-m-u
Copy link
Contributor Author

d-m-u commented Aug 20, 2018

@abellotti or @gtanzillo or anyone can you please 👀 for me?

@gtanzillo
Copy link
Member

@d-m-u Is this change covered by an existing test?

@d-m-u
Copy link
Contributor Author

d-m-u commented Aug 21, 2018

@miq-bot

This comment has been minimized.

@miq-bot

This comment has been minimized.

@miq-bot

This comment has been minimized.

@d-m-u d-m-u closed this Aug 22, 2018
@d-m-u d-m-u reopened this Aug 22, 2018
@d-m-u d-m-u closed this Aug 28, 2018
@d-m-u d-m-u reopened this Aug 28, 2018
@d-m-u d-m-u changed the title Pass changed dialog field values to resource_action_workflow [WIP] Pass changed dialog field values to resource_action_workflow Aug 28, 2018
@miq-bot miq-bot added the wip label Aug 28, 2018
@d-m-u d-m-u closed this Sep 12, 2018
@d-m-u d-m-u reopened this Sep 12, 2018
@d-m-u d-m-u changed the title [WIP] Pass changed dialog field values to resource_action_workflow Pass changed dialog field values to resource_action_workflow Sep 12, 2018
@d-m-u
Copy link
Contributor Author

d-m-u commented Sep 12, 2018

@miq-bot remove_label wip

@miq-bot miq-bot removed the wip label Sep 12, 2018
@d-m-u
Copy link
Contributor Author

d-m-u commented Sep 12, 2018

@miq-bot add_reviewer @bdunne

@miq-bot miq-bot requested a review from bdunne September 12, 2018 15:44
@d-m-u
Copy link
Contributor Author

d-m-u commented Sep 12, 2018

@miq-bot remove_label blocker
labels are difficult

@miq-bot miq-bot removed the blocker label Sep 12, 2018
@bdunne bdunne merged commit d4520f8 into ManageIQ:master Sep 12, 2018
@bdunne bdunne added this to the Sprint 95 Ending Sep 24, 2018 milestone Sep 12, 2018
@bdunne bdunne self-assigned this Sep 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants