Adjust ConversionHost support check so that it uses resource instead of singleton #600
Conversation
|
Checked commits https://github.com/djberg96/manageiq-api/compare/47de45359b50f9588e0b750ad501c60e90e116cc~...d9f94537c0e356c05a8c1fed263f22a46f9b5d1f with ruby 2.3.3, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@miq-bot add_labels transformation, hammer/yes |
| @@ -53,9 +53,11 @@ | |||
| context "create" do | |||
| let(:zone) { FactoryBot.create(:zone) } | |||
| let(:ems_openstack) { FactoryBot.create(:ems_openstack, :zone => zone) } | |||
| let(:ems_redhat) { FactoryBot.create(:ems_redhat, :zone => zone) } | |||
| let(:ems_redhat) { FactoryBot.create(:ems_redhat, :zone => zone, :api_version => '4.2.4') } | |||
There was a problem hiding this comment.
There's an :ems_redhat_v4 factory, is 4.2.4 important?
There was a problem hiding this comment.
@bdunne We have a minimum api version for redhat conversion hosts of 4.2.4, and the factory is 4.0.
There was a problem hiding this comment.
I imagine the factory could probably be updated, but didn't want to touch it for now since it could affect tests outside of v2v.
There was a problem hiding this comment.
@bdunne We have a minimum api version for redhat conversion hosts of 4.2.4, and the factory is 4.0.
Okay.
I imagine the factory could probably be updated, but didn't want to touch it for now since it could affect tests outside of v2v.
No, I think that makes it even less obvious that this api version is important here.
Adjust ConversionHost support check so that it uses resource instead of singleton (cherry picked from commit a8dc191) https://bugzilla.redhat.com/show_bug.cgi?id=1717023
|
Hammer backport details: |
This PR updates the ConversionHostController#create method so that the supports check happens at the instance level instead of the singleton level. I also updated the comments slightly.
Effectively replaces ManageIQ/manageiq#18799, since fiddling with the resource_type won't matter any more.
https://bugzilla.redhat.com/show_bug.cgi?id=1713394