Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Changelog] Update for Hammer-10 #347

Merged
merged 3 commits into from
Aug 9, 2019
Merged

Conversation

JPrause
Copy link
Member

@JPrause JPrause commented Aug 9, 2019

[skip ci]

@JPrause
Copy link
Member Author

JPrause commented Aug 9, 2019

@miq-bot add_label documentation

@JPrause
Copy link
Member Author

JPrause commented Aug 9, 2019

@miq-bot add_label hammer/yes

CHANGELOG.md Outdated
## Hammer-10

### Fixed
- Don't set User.current_user [(#293)](https://github.com/ManageIQ/manageiq-automation_engine/pull/293)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JPrause I feel a more accurate title for this PR would be Replace "User.current_user" with "User.with_user"

@tinaafitz Are you ok with this? Should we change the PR title as well?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @JPrause I wanted to title to read as the whole string below:

Replace User.current_user with User.with_user

I removed the quotes this time. Also updated the PR to match.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries,...I guess a literal guy. Ha! Will update now.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and I went over to the PR to make sure I got it right. 😄

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wondering if I did that with you in mind. 🤔

Thanks for the updates @JPrause

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gmcculloug yes, that makes sense. I saw that PR title was updated.

@coveralls
Copy link

coveralls commented Aug 9, 2019

Pull Request Test Coverage Report for Build 2869

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 85.13%

Totals Coverage Status
Change from base Build 2822: 0.1%
Covered Lines: 4952
Relevant Lines: 5817

💛 - Coveralls

@gmcculloug
Copy link
Member

@bdunne Are we using [skip_ci] in the description properly? The running Travis test would indicate maybe we aren't.

@miq-bot
Copy link
Member

miq-bot commented Aug 9, 2019

Checked commits JPrause/manageiq-automation_engine@c4af255~...0a026a8 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🏆

@gmcculloug gmcculloug merged commit 77ebffd into ManageIQ:master Aug 9, 2019
simaishi pushed a commit that referenced this pull request Aug 9, 2019
[Changelog] Update for Hammer-10

(cherry picked from commit 77ebffd)
@simaishi
Copy link
Contributor

simaishi commented Aug 9, 2019

Hammer backport details:

$ git log -1
commit 771d999e4bcf2dc99c742734de313f11c5b19913
Author: Greg McCullough <gmccullo@redhat.com>
Date:   Fri Aug 9 15:38:42 2019 -0400

    Merge pull request #347 from JPrause/hammer10_cl
    
    [Changelog] Update for Hammer-10
    
    (cherry picked from commit 77ebffd419ce07b99c8b6d5b4813848fa97a1e51)

@bdunne
Copy link
Member

bdunne commented Aug 12, 2019

@bdunne Are we using [skip_ci] in the description properly? The running Travis test would indicate maybe we aren't.

https://docs.travis-ci.com/user/customizing-the-build/#skipping-a-build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants