-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Changelog] Update for Hammer-10 #347
Conversation
[skip ci]
@miq-bot add_label documentation |
@miq-bot add_label hammer/yes |
CHANGELOG.md
Outdated
## Hammer-10 | ||
|
||
### Fixed | ||
- Don't set User.current_user [(#293)](https://github.com/ManageIQ/manageiq-automation_engine/pull/293) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JPrause I feel a more accurate title for this PR would be Replace "User.current_user" with "User.with_user"
@tinaafitz Are you ok with this? Should we change the PR title as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry @JPrause I wanted to title to read as the whole string below:
Replace User.current_user with User.with_user
I removed the quotes this time. Also updated the PR to match.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries,...I guess a literal guy. Ha! Will update now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and I went over to the PR to make sure I got it right. 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wondering if I did that with you in mind. 🤔
Thanks for the updates @JPrause
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gmcculloug yes, that makes sense. I saw that PR title was updated.
Pull Request Test Coverage Report for Build 2869
💛 - Coveralls |
@bdunne Are we using |
Checked commits JPrause/manageiq-automation_engine@c4af255~...0a026a8 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
[Changelog] Update for Hammer-10 (cherry picked from commit 77ebffd)
Hammer backport details:
|
https://docs.travis-ci.com/user/customizing-the-build/#skipping-a-build |
[skip ci]