Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change errors in log to error type. #101

Merged
merged 1 commit into from
Apr 26, 2017
Merged

Change errors in log to error type. #101

merged 1 commit into from
Apr 26, 2017

Conversation

billfitzgerald0120
Copy link
Contributor

Some error messages in log were type info.

https://bugzilla.redhat.com/show_bug.cgi?id=1383732

@miq-bot add_label bug, fine/yes

@billfitzgerald0120
Copy link
Contributor Author

@miq-bot add_label euwe/yes

@miq-bot
Copy link
Member

miq-bot commented Apr 24, 2017

Checked commit billfitzgerald0120@008b70d with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
5 files checked, 0 offenses detected
Everything looks good. 👍

@billfitzgerald0120
Copy link
Contributor Author

@tinaafitz
Please review

@gmcculloug gmcculloug merged commit 4bf5377 into ManageIQ:master Apr 26, 2017
@gmcculloug gmcculloug added this to the Sprint 60 Ending May 8, 2017 milestone Apr 26, 2017
@simaishi
Copy link
Contributor

Cherry-picked for 2 files that exist in Euwe branch

  • ConfigurationManagement/AnsibleTower/Service/Provisioning/StateMachines/Provision.class/__methods__/check_provisioned.rb
  • Deployment/ContainerProvider/System/StateMachine/Deployment.class/__methods__/provision.rb

Euwe backport (to manageiq repo) details:

$ git log -1
commit b615b755b364893038bdfa9cac9ff89be6facbcc
Author: Greg McCullough <gmccullo@redhat.com>
Date:   Wed Apr 26 08:50:12 2017 -0400

    Merge pull request #101 from billfitzgerald0120/log_cleanup1
    
    Change errors in log to error type.
    (cherry picked from commit 4bf53776c5f87096502faf60d335f34883f48cdf)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1450214

simaishi pushed a commit that referenced this pull request Jun 6, 2017
@gmcculloug @simaishi
Merge pull request #101 from billfitzgerald0120/log_cleanup1
fe6ccb5 
Change errors in log to error type.
(cherry picked from commit 4bf5377)

https://bugzilla.redhat.com/show_bug.cgi?id=1459243
@simaishi
Copy link
Contributor

simaishi commented Jun 6, 2017

Fine backport details:

$ git log -1
commit fe6ccb57ab74e6dd7f78c2ae891978672fdae4ca
Author: Greg McCullough <gmccullo@redhat.com>
Date:   Wed Apr 26 08:50:12 2017 -0400

    Merge pull request #101 from billfitzgerald0120/log_cleanup1
    
    Change errors in log to error type.
    (cherry picked from commit 4bf53776c5f87096502faf60d335f34883f48cdf)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1459243

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug euwe/backported fine/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@billfitzgerald0120 @miq-bot @simaishi @gmcculloug