Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change exceeds message in log to warn type. #104

Merged
merged 5 commits into from
May 8, 2017

Conversation

billfitzgerald0120
Copy link
Contributor

@miq-bot
Copy link
Member

miq-bot commented Apr 26, 2017

@billfitzgerald0120 Cannot apply the following label because they are not recognized: fine/yes. euwe/yes

@miq-bot miq-bot added the bug label Apr 26, 2017
Log message will match notification message in all 7 methods.
https://bugzilla.redhat.com/show_bug.cgi?id=1383732

@miq-bot add_label fine/yes, euwe/yes
@billfitzgerald0120
Copy link
Contributor Author

@miq-bot add_label fine/yes, euwe/yes

@billfitzgerald0120
Copy link
Contributor Author

@tinaafitz
Please Review

@miq-bot
Copy link
Member

miq-bot commented Apr 27, 2017

Checked commits billfitzgerald0120/manageiq-content@512b4d6~...8d0d4a8 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
16 files checked, 0 offenses detected
Everything looks fine. ⭐

@billfitzgerald0120
Copy link
Contributor Author

@tinaafitz
Please Review

@tinaafitz
Copy link
Member

@billfitzgerald0120 Looks good.
@mkanoor Please review.

@mkanoor mkanoor merged commit 5330cb9 into ManageIQ:master May 8, 2017
@mkanoor mkanoor added this to the Sprint 60 Ending May 8, 2017 milestone May 8, 2017
@simaishi
Copy link
Contributor

@billfitzgerald0120 Half the files are conflicting during cherry-pick. Can you please create an Euwe PR for this?

@billfitzgerald0120
Copy link
Contributor Author

@simaishi
We are not going to backport this to Euwe.

simaishi pushed a commit that referenced this pull request Jun 6, 2017
@simaishi
Copy link
Contributor

simaishi commented Jun 6, 2017

Fine backport details:

$ git log -1
commit 76c00db8c70117a3305e09f79106f4b43a367991
Author: Madhu Kanoor <mkanoor@redhat.com>
Date:   Mon May 8 14:06:34 2017 -0400

    Merge pull request #104 from billfitzgerald0120/log_cleanup2
    
    Change exceeds message in log to warn type.
    (cherry picked from commit 5330cb9f558da906d6bd2ed94f9ff07658defa0b)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1459243

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants