Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support embedded_ansible to fetch credentials from provider #112

Merged
merged 1 commit into from
May 9, 2017

Conversation

mkanoor
Copy link
Contributor

@mkanoor mkanoor commented May 9, 2017

https://bugzilla.redhat.com/show_bug.cgi?id=1448918

If we dont find a ansible provider thru the service template and
the method gets passed in a parameter embedded_ansible true we use
the first Embedded Ansible Provider and collect the credentials
connected to it

https://bugzilla.redhat.com/show_bug.cgi?id=1448918

If we dont find a ansible provider thru the service template and
the method gets passed in a parameter embedded_ansible true we use
the first Embedded Ansible Provider and collect the credentials
connected to it
@mkanoor
Copy link
Contributor Author

mkanoor commented May 9, 2017

@bzwei @tinaafitz @gmcculloug
Please review

@miq-bot
Copy link
Member

miq-bot commented May 9, 2017

Checked commit mkanoor@af395c7 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks fine. 🏆

@chrispy1
Copy link

chrispy1 commented May 9, 2017

@miq-bot add_label blocker

@bzwei
Copy link
Contributor

bzwei commented May 9, 2017

LGTM

@miq-bot miq-bot added the blocker label May 9, 2017
@tinaafitz
Copy link
Member

@mkanoor Looks good.

@gmcculloug gmcculloug merged commit 519518a into ManageIQ:master May 9, 2017
@gmcculloug gmcculloug added this to the Sprint 61 Ending May 22, 2017 milestone May 9, 2017
simaishi pushed a commit that referenced this pull request May 9, 2017
Support embedded_ansible to fetch credentials from provider
(cherry picked from commit 519518a)

https://bugzilla.redhat.com/show_bug.cgi?id=1449366
@simaishi
Copy link
Contributor

simaishi commented May 9, 2017

Fine backport details:

$ git log -1
commit 2ce9007026cbf04e87b30089a3784199fc8569ad
Author: Greg McCullough <gmccullo@redhat.com>
Date:   Tue May 9 12:27:07 2017 -0400

    Merge pull request #112 from mkanoor/bz_1448918
    
    Support embedded_ansible to fetch credentials from provider
    (cherry picked from commit 519518a27bf69ed70de269cff1cd68a22e95a4d7)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1449366

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants