Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed ae_retry_limit = 1.minute to ae_retry_interval = 1.minute. #151

Merged

Conversation

billfitzgerald0120
Copy link
Contributor

Changes made in Wait_for_ip and Wait_for_completion methods in
ConfigurationManagement namespace.

https://bugzilla.redhat.com/show_bug.cgi?id=1474748

@miq-bot add_label bug, fine/yes, euwe/yes
@miq-bot assign @gmcculloug

…2 methods.

Changes made in Wait_for_ip and Wait_for_completion methods in
ConfigurationManagement namespace.

https://bugzilla.redhat.com/show_bug.cgi?id=1474748

@miq-bot add_label bug, fine/yes, euwe/yes
@miq-bot assign @gmcculloug
@miq-bot
Copy link
Member

miq-bot commented Jul 25, 2017

Checked commit billfitzgerald0120@2cabbfb with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks fine. ⭐

@billfitzgerald0120
Copy link
Contributor Author

@tinaafitz
Please Review

@gmcculloug gmcculloug merged commit 0ee9bd4 into ManageIQ:master Jul 25, 2017
@gmcculloug gmcculloug added this to the Sprint 66 Ending Aug 7, 2017 milestone Jul 25, 2017
simaishi pushed a commit that referenced this pull request Aug 8, 2017
Changed ae_retry_limit = 1.minute to ae_retry_interval = 1.minute.
(cherry picked from commit 0ee9bd4)

https://bugzilla.redhat.com/show_bug.cgi?id=1479409
@simaishi
Copy link
Contributor

simaishi commented Aug 8, 2017

Fine backport details:

$ git log -1
commit d73d6ad139976ac1777706962f92b0091fd21897
Author: Greg McCullough <gmccullo@redhat.com>
Date:   Tue Jul 25 17:23:48 2017 -0400

    Merge pull request #151 from billfitzgerald0120/fix_ae_retry_interval
    
    Changed ae_retry_limit = 1.minute to ae_retry_interval = 1.minute.
    (cherry picked from commit 0ee9bd467697aed5cc92f85f1210b4ceed73a87a)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1479409

@psachin
Copy link
Contributor

psachin commented Aug 11, 2017

@billfitzgerald0120

I see ConfigurationManagement is deprecated and AutomationManagement takes over. But AutomationManagement still has ae_retry_limit. Are you going to change that too?

@gmcculloug
Copy link
Member

@psachin That namespace was updated in PR #152.

@psachin
Copy link
Contributor

psachin commented Aug 11, 2017

@gmcculloug Thanks for the info

@simaishi
Copy link
Contributor

Euwe backport (to manageiq repo) details:

$ git log -1
commit 78619b5e97e9c294e6506d078fb4dcda9dc5c323
Author: Greg McCullough <gmccullo@redhat.com>
Date:   Tue Jul 25 17:23:48 2017 -0400

    Merge pull request #151 from billfitzgerald0120/fix_ae_retry_interval
    
    Changed ae_retry_limit = 1.minute to ae_retry_interval = 1.minute.
    (cherry picked from commit 0ee9bd467697aed5cc92f85f1210b4ceed73a87a)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1479410

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants