Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target template related actions #153

Merged
merged 1 commit into from
Sep 11, 2017
Merged

Conversation

pkliczewski
Copy link
Contributor

@pkliczewski pkliczewski commented Jul 28, 2017

As part of our performance improvements we want to reduce the scope of a
refresh when adding and removing templates.

Depends on ManageIQ/manageiq-providers-ovirt#70

Bug-Url:
https://bugzilla.redhat.com/1451577

As part of our performance improvements we want to reduce the scope of a
refresh when adding and removing templates.

Bug-Url:
https://bugzilla.redhat.com/1451577
@pkliczewski
Copy link
Contributor Author

This patch depends on ManageIQ/manageiq-providers-ovirt#70 and it needs to be merged first.

@miq-bot
Copy link
Member

miq-bot commented Jul 28, 2017

Checked commit pkliczewski@7e4ee46 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks fine. 👍

@pkliczewski
Copy link
Contributor Author

@oourfali
Copy link

@gmcculloug can you please review this one?
Thanks!

@gmcculloug gmcculloug removed the wip label Sep 8, 2017
@gmcculloug
Copy link
Member

gmcculloug commented Sep 8, 2017

Removed WIP label now that dependent PR is merged.

@gmcculloug
Copy link
Member

@pkliczewski Were you able to test these changes on a live system? Is the src_vm always available in the db at the time the event is processed? Before that was not always the case for "New VM" events, but I know RHV creates the basic VM instance based on an event.

cc @lfu

@pkliczewski
Copy link
Contributor Author

@gmcculloug When the object is not there we use event_action_refresh_new_target to make sure we create it before the refresh. Yes, I have tested it on my env.

@lfu
Copy link
Member

lfu commented Sep 11, 2017

LGTM 👍

@gmcculloug gmcculloug merged commit b78e15c into ManageIQ:master Sep 11, 2017
@gmcculloug gmcculloug added this to the Sprint 69 Ending Sep 18, 2017 milestone Sep 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants