Support TTL (Time To Live) value for services. #162
Conversation
|
@tinaafitz Please review |
|
This pull request is not mergeable. Please rebase and repush. |
| @@ -55,6 +72,8 @@ def check_completed(service) | |||
| end | |||
| else | |||
| @handle.root['ae_result'] = 'retry' | |||
| @handle.root['ae_retry_interval'] = 1.minute | |||
There was a problem hiding this comment.
@billfitzgerald0120 Since we setup a method for calculating ae_retry_interval I would expect this default value to move into there to keep the logic all together. It is also better for testing.
billfitzgerald0120
force-pushed
the
check_completed
branch
from
4229e37
to
a9ece9e
Compare
|
Greg - Made changes as you requested. |
|
@tinaafitz Please Review |
| it_behaves_like "#ttl" | ||
| end | ||
|
|
||
| context "600 ttl, 100 retries eq interval 6" do |
There was a problem hiding this comment.
@tinaafitz whats the difference between these different scenarios could we just use 1 test. maybe the 300 ttl or the 600 ttl
There was a problem hiding this comment.
@mkanoor There's no difference. We'll remove one of the tests.
Allow specifying the length of time to allow the check_completed step to run in the generic service state-machine. This will allow long running processes to finish. UI changes done. https://www.pivotaltracker.com/n/projects/1937537/stories/147361947 https://bugzilla.redhat.com/show_bug.cgi?id=1459735 Initial PR: ManageIQ#148 Moved interval calculations from start to check_completed.
billfitzgerald0120
force-pushed
the
check_completed
branch
from
a9ece9e
to
220fa1e
Compare
|
Checked commit billfitzgerald0120@220fa1e with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@miq-bot add_label fine/yes |
Support TTL (Time To Live) value for services. (cherry picked from commit 7d66b4b) https://bugzilla.redhat.com/show_bug.cgi?id=1479407
|
Fine backport details: |
Allow specifying the length of time to allow the check_completed step to run in the generic service state-machine.
This will allow long running processes to finish.
UI changes done.
https://www.pivotaltracker.com/n/projects/1937537/stories/147361947
https://bugzilla.redhat.com/show_bug.cgi?id=1459735
Depends on:
#186
ManageIQ/manageiq-automation_engine#46
@miq-bot add_label enhancement, services
@miq-bot assign @gmcculloug