Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS DetachVolume event switchboard setting. #164

Merged
merged 1 commit into from Aug 7, 2017
Merged

AWS DetachVolume event switchboard setting. #164

merged 1 commit into from Aug 7, 2017

Conversation

bronaghs
Copy link

@bronaghs bronaghs commented Aug 4, 2017

This PR will configure an event in the event switchboard for the Amazon EBS DetachVolume event.

Testing:

  • Add an AWS provider
  • Identify a VM with an EBS cloud volume attached
  • Through the AWS console, detach the volume from the VM
  • In the ManageIQ UI, make sure the volume is no longer attached to the VM. This will indicate an event was received and went through the event switchboard where an EMS refresh was kicked off.

Links:

https://www.pivotaltracker.com/story/show/146650341
https://bugzilla.redhat.com/show_bug.cgi?id=1472975

@bronaghs
Copy link
Author

bronaghs commented Aug 4, 2017

@miq-bot add_label enhancement

@miq-bot
Copy link
Member

miq-bot commented Aug 4, 2017

Checked commit bronaghs@68b649c with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks fine. 🍪

@gmcculloug gmcculloug self-assigned this Aug 4, 2017
@gmcculloug
Copy link
Member

@lfu Please review

@lfu
Copy link
Member

lfu commented Aug 4, 2017

LGTM 👍

@gmcculloug gmcculloug merged commit 7e34525 into ManageIQ:master Aug 7, 2017
@gmcculloug gmcculloug added this to the Sprint 66 Ending Aug 7, 2017 milestone Aug 7, 2017
@bronaghs
Copy link
Author

@miq_bot add_label fine/yes

@bronaghs bronaghs deleted the aws_detachvolume branch October 26, 2017 17:40
simaishi pushed a commit that referenced this pull request Nov 2, 2017
@gmcculloug @simaishi
Merge pull request #164 from bronaghs/aws_detachvolume
bb2a9f7 
AWS DetachVolume event switchboard setting.
(cherry picked from commit 7e34525)

https://bugzilla.redhat.com/show_bug.cgi?id=1500954
@simaishi
Copy link
Contributor

simaishi commented Nov 2, 2017

Fine backport details:

$ git log -1
commit bb2a9f7d02cb0e22fe336f12d7243ac6b23f9830
Author: Greg McCullough <gmccullo@redhat.com>
Date:   Mon Aug 7 13:11:49 2017 -0400

    Merge pull request #164 from bronaghs/aws_detachvolume
    
    AWS DetachVolume event switchboard setting.
    (cherry picked from commit 7e3452501dfa146d81f9f0fde1d2d312d80a6ef9)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1500954

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gmcculloug gmcculloug

Labels
enhancement events fine/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bronaghs @miq-bot @gmcculloug @lfu @simaishi