Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do targeted refresh based on Openstack events. #184

Merged

Conversation

mansam
Copy link
Contributor

@mansam mansam commented Sep 8, 2017

@Ladas Does this make sense to you?

@gmcculloug gmcculloug self-assigned this Sep 8, 2017
@gmcculloug
Copy link
Member

@lfu Please review

@mansam mansam force-pushed the openstack-targeted-refresh-based-on-events branch from a027210 to 33e254d Compare September 8, 2017 15:26
@miq-bot
Copy link
Member

miq-bot commented Sep 8, 2017

Checked commit mansam@33e254d with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks fine. 🍰

@lfu
Copy link
Member

lfu commented Sep 8, 2017

The changes look good.

Please follow the steps in Creating a Pull Request for enhancements to ManageIQ Automate Domain to keep the YAML files format consistent.

Copy link
Contributor

@Ladas Ladas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. 👍

@gmcculloug
Copy link
Member

@mansam Did you follow the process @lfu mentioned here: #184 (comment) ?

Just trying to validate, thanks.

@mansam
Copy link
Contributor Author

mansam commented Sep 26, 2017

@gmcculloug Hi Greg, yes.

@gmcculloug gmcculloug merged commit 2c1d828 into ManageIQ:master Sep 26, 2017
@gmcculloug gmcculloug added this to the Sprint 70 Ending Oct 2, 2017 milestone Sep 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants