Fixed calculation for Ansible playbook service max TTL. #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot assign @gmcculloug |
|
@tinaafitz Please Review |
|
@billfitzgerald0120 Looks good. |
gmcculloug
reviewed
Oct 5, 2017
| context "600 ttl, 100 retries eq interval 6" do | ||
| let(:ae_retry_interval) { 6.minutes } | ||
| let(:ttl) { 600 } | ||
| context "650 ttl, 100 retries eq interval 6" do |
There was a problem hiding this comment.
Also need to update the "internal" value of the context.
| context "600 ttl, 100 retries eq interval 6" do | ||
| let(:ae_retry_interval) { 6.minutes } | ||
| let(:ttl) { 600 } | ||
| context "650 ttl, 100 retries eq interval 6" do |
billfitzgerald0120
force-pushed
the
timetolive_float
branch
from
84e4883
to
db4c6ef
Compare
|
@gmcculloug Made changes as requested, please review |
|
Checked commit billfitzgerald0120@db4c6ef with ruby 2.3.5, rubocop 0.47.1, and haml-lint 0.20.0 |
gmcculloug
approved these changes
Oct 5, 2017
simaishi
pushed a commit
that referenced
this pull request
Nov 13, 2017
Fixed calculation for Ansible playbook service max TTL. (cherry picked from commit ae2736d) https://bugzilla.redhat.com/show_bug.cgi?id=1501524
|
Fine backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated method and test.
https://bugzilla.redhat.com/show_bug.cgi?id=1497983
@miq-bot add_label bug, fine/yes