Add policy resolution call to vm_destroy for providers. #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lfu Are there other provider events that this policy event should be tied to? |
Removing a virtual machine in RHEV is final and cannot be reversed. https://bugzilla.redhat.com/show_bug.cgi?id=1506520
lfu
force-pushed
the
destroy_vm_1506520
branch
from
8d1413e
to
a0b9857
Compare
lfu
changed the title
@lfu RHV has the option as well but as far as I know VMware is the only one with a different API call to do this |
|
/cc @pkliczewski |
|
Looks good, verified for ovirt. |
|
Checked commits lfu/manageiq-content@2c56415~...a0b9857 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 **
|
simaishi
pushed a commit
that referenced
this pull request
Jan 10, 2018
Add policy resolution call to vm_destroy for providers. (cherry picked from commit 78dcaa8) https://bugzilla.redhat.com/show_bug.cgi?id=1533279
|
Gaprindashvili backport details: |
simaishi
pushed a commit
that referenced
this pull request
Jan 15, 2018
Add policy resolution call to vm_destroy for providers. (cherry picked from commit 78dcaa8) https://bugzilla.redhat.com/show_bug.cgi?id=1534584
|
Fine backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vm_destroy is the policy event raised when a VM is deleted from disk from VMware side.
vm_unregister is the policy event raised when a VM is removed from inventory from VMware side.
Add vm_destroy call for all providers.
Seems VMware is the only one which has the option to remove VM from inventory besides delete VM from disk. @agrare @bronaghs, is it right?
Part of ManageIQ/manageiq#16557.
https://bugzilla.redhat.com/show_bug.cgi?id=1506520
@miq-bot add_label bug, fine/yes, gaprindashvili/yes