Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force full refresh for router based events #224

Merged
merged 1 commit into from
Dec 4, 2017
Merged

Force full refresh for router based events #224

merged 1 commit into from
Dec 4, 2017

Conversation

Ladas
Copy link
Contributor

@Ladas Ladas commented Nov 30, 2017

Force full refresh for router based events. We are not able to
do targeted refresh for routers, until we have changes that will
land for h-release

Fixes BZ:
https://bugzilla.redhat.com/show_bug.cgi?id=1518826

@Ladas
Force full refresh for router based events
b762ddb 
Force full refresh for router based events. We are not able to
do targeted refresh for routers, until we have changes that will
land for h-release

Fixes BZ:
https://bugzilla.redhat.com/show_bug.cgi?id=1518826
@Ladas
Copy link
Contributor Author

Ladas commented Nov 30, 2017

@miq-bot assign @gmcculloug
@miq-bot add_label bug

cc @blomquisg @bronaghs

@miq-bot miq-bot added the bug label Nov 30, 2017
@miq-bot
Copy link
Member

miq-bot commented Nov 30, 2017

Checked commit Ladas@b762ddb with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
10 files checked, 1 offense detected

**

  • 💣 💥 🔥 🚒 - Linter/Yaml - missing config files

@gmcculloug
Copy link
Member

@lfu Please review

@lfu
Copy link
Member

lfu commented Dec 4, 2017

LGTM 👍

@gmcculloug gmcculloug merged commit 8b57e3a into ManageIQ:master Dec 4, 2017
@gmcculloug gmcculloug added this to the Sprint 75 Ending Dec 11, 2017 milestone Dec 4, 2017
@simaishi
Copy link
Contributor

simaishi commented Dec 5, 2017

gaprindashvili/yes ?

@Ladas
Copy link
Contributor Author

Ladas commented Dec 5, 2017

@miq-bot add_label gaprindashvili/yes

simaishi pushed a commit that referenced this pull request Dec 5, 2017
@gmcculloug @simaishi
Merge pull request #224 from Ladas/force_full_refresh_for_amazon_rout…
3187e46 
…er_events

Force full refresh for router based events
(cherry picked from commit 8b57e3a)

https://bugzilla.redhat.com/show_bug.cgi?id=1520973
@simaishi
Copy link
Contributor

simaishi commented Dec 5, 2017

Gaprindashvili backport details:

$ git log -1
commit 3187e46b76445db66cb1ecacb554890cadef31b6
Author: Greg McCullough <gmccullo@redhat.com>
Date:   Mon Dec 4 11:07:41 2017 -0500

    Merge pull request #224 from Ladas/force_full_refresh_for_amazon_router_events
    
    Force full refresh for router based events
    (cherry picked from commit 8b57e3a733766f8d0fb951fb34954f2fd95188f3)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1520973

@chrispy1
Copy link

@miq-bot add_label fine/yes

@simaishi
Copy link
Contributor

@Ladas @gmcculloug Looks like this depends on #217. Can this PR and PR 217 go to fine branch?

@Ladas
Copy link
Contributor Author

Ladas commented Jan 29, 2018

@simaishi hello, yeah, it depends on #217, so if we would want to backport to Fine, we would have to do a special Fine PR, with the correct refresh actions.

@simaishi simaishi removed the fine/yes label Mar 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gmcculloug gmcculloug

Labels
bug events gaprindashvili/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Ladas @miq-bot @gmcculloug @lfu @simaishi @chrispy1