Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed the schema values for PreDeleteFromProvider. #226

Merged

Conversation

billfitzgerald0120
Copy link
Contributor

Removed the schema values for PreDeleteFromProvider in /Infrastructure and /Cloud VM retirement state machine classes.

The Infrastructure/cloud vm retirement state machines have a commented out entry for predeletefromprovider which could (and did) give users the impression they can uncomment it for additional functionality which is not the case.

https://bugzilla.redhat.com/show_bug.cgi?id=1518858

…ass schema values for the PreDeleteFromProvider.

The Infrastructure/cloud vm retirement state machines have a commented out entry for predeletefromprovider which could (and did) give users the impression they can uncomment it for additional functionality which is not the case.

https://bugzilla.redhat.com/show_bug.cgi?id=1518858
@billfitzgerald0120
Copy link
Contributor Author

@miq-bot add_label bug
@miq-bot assign @gmcculloug

@miq-bot
Copy link
Member

miq-bot commented Dec 8, 2017

Checked commit billfitzgerald0120@1641f4a with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 1 offense detected

**

  • 💣 💥 🔥 🚒 - Linter/Yaml - missing config files

Copy link
Member

@tinaafitz tinaafitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@gmcculloug gmcculloug merged commit 6fc9d68 into ManageIQ:master Dec 11, 2017
@gmcculloug gmcculloug added this to the Sprint 75 Ending Dec 11, 2017 milestone Dec 11, 2017
simaishi pushed a commit that referenced this pull request Dec 12, 2017
…rovider

Removed the schema values for PreDeleteFromProvider.
(cherry picked from commit 6fc9d68)
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit a799e9c064d207c72ba950a8aaced63282788a74
Author: Greg McCullough <gmccullo@redhat.com>
Date:   Mon Dec 11 14:26:11 2017 -0500

    Merge pull request #226 from billfitzgerald0120/remove_predeletefromprovider
    
    Removed the schema values for PreDeleteFromProvider.
    (cherry picked from commit 6fc9d6875baf427af85c49afc874b7119bc9588e)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants