Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automation for transformation plan #244

Merged
merged 2 commits into from Feb 8, 2018
Merged

Automation for transformation plan #244

merged 2 commits into from Feb 8, 2018

Conversation

bzwei
Copy link
Contributor

@bzwei bzwei commented Jan 31, 2018 •
edited

New namespace Transformation
New System/Policy instances for ServiceTemplateTransformationPlanRequest events

Design document: ManageIQ/manageiq-design#39

This is the initial work to demonstrate the workflow and file structure.

It works locally in my dev env. It has dependencies on service models introduced in ManageIQ/manageiq-automation_engine#155

@bzwei
Copy link
Contributor Author

bzwei commented Jan 31, 2018

@tinaafitz @fdupont-redhat @pemcg please review

@miq-bot miq-bot added the wip label Jan 31, 2018
@ghost
Copy link

ghost commented Jan 31, 2018

Looks good to me. As you say, it's a first iteration that will evolve.

@bzwei
Copy link
Contributor Author

bzwei commented Feb 6, 2018

@miq-bot add_label v2v

@miq-bot
Copy link
Member

miq-bot commented Feb 6, 2018

@bzwei Cannot apply the following label because they are not recognized: v2v

@lfu lfu force-pushed the v2v_init branch 2 times, most recently from 40493d9 to 63ba6e9 Compare February 7, 2018 17:25
@lfu
Copy link
Member

lfu commented Feb 7, 2018 •
edited

New names for automate namespace and classes.
screen shot 2018-02-08 at 10 25 39 am

New /System/Policy instances.
screen shot 2018-02-07 at 2 09 27 pm

lfu
lfu reviewed Feb 7, 2018
View reviewed changes
...ManageIQ/System/CommonMethods/StateMachineMethods.class/transformation_plan_vm_finished.yaml Outdated
description:
fields:
- execute:
value: task_finished(object => 'transformation_plan_task', message => 'VM Migrated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bzwei Does this object => 'transformation_plan_task' make sense here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

service_template_transformation_plan_task

bzwei
bzwei commented Feb 7, 2018
View reviewed changes
content/automate/ManageIQ/System/Policy.class/transformationplanrequest_approved.yaml Outdated
object:
attributes:
display_name:
name: TransformationPlanRequest_approved
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should use the full name (ServiceTemplateTransformationPlanRequest_approved and the file name) everywhere under /System

@lfu
Copy link
Member

lfu commented Feb 7, 2018

@mkanoor @tinaafitz Please review.

@bzwei
Copy link
Contributor Author

bzwei commented Feb 7, 2018

LGTM

@bzwei @lfu
Initial work for tranformation plan
30cc25b 
New namespace Transformation
New System/Policy instances for TransformationPlanRequest events
@gmcculloug gmcculloug added the v2v label Feb 7, 2018
@gmcculloug
Copy link
Member

@bzwei @lfu Should the wip label be removed now?

@lfu
Copy link
Member

lfu commented Feb 7, 2018

@bzwei The wip label can be removed. Ready for final review.

@lfu
Copy link
Member

lfu commented Feb 7, 2018

@billfitzgerald0120 Can you review the changes for Email notification?

@billfitzgerald0120
Copy link
Contributor

@lfu LGTM

mkanoor
mkanoor reviewed Feb 8, 2018
View reviewed changes
...omate/ManageIQ/System/Notification/Email.class/transformationplanrequestapproverpending.yaml Outdated
fields:
- subject:
value: Request ID ${/#miq_request.id} - Transformation Plan Request from <${/#miq_request.requester.email}>
Failed Auto-Approval.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bzwei Should this say "Pending Approval" instead of "Failed Auto-Approval"

tinaafitz
tinaafitz approved these changes Feb 8, 2018
View reviewed changes
Copy link
Member

@tinaafitz tinaafitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lfu Looks good.

@lfu
Update on Bill's initial work for tranformation plan
2afde79 
New namespace Transformation
New System/Policy instances for TransformationPlanRequest events
@miq-bot
Copy link
Member

miq-bot commented Feb 8, 2018

Checked commits bzwei/manageiq-content@30cc25b~...2afde79 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
25 files checked, 1 offense detected

**

  • 💣 💥 🔥 🚒 - Linter/Yaml - missing config files

@bzwei bzwei changed the title [wip] Initial work for migration plan Automation for transformation plan Feb 8, 2018
@miq-bot miq-bot removed the wip label Feb 8, 2018
@gmcculloug gmcculloug merged commit 684d7b1 into ManageIQ:master Feb 8, 2018
@gmcculloug gmcculloug added this to the Sprint 79 Ending Feb 12, 2018 milestone Feb 8, 2018
@gmcculloug gmcculloug self-assigned this Feb 8, 2018
simaishi pushed a commit that referenced this pull request May 29, 2018
@gmcculloug @simaishi
Merge pull request #244 from bzwei/v2v_init
f59730b 
Automation for transformation plan
(cherry picked from commit 684d7b1)
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit f59730b2227d687435edf57d438033a9fdae4454
Author: Greg McCullough <gmccullo@redhat.com>
Date:   Thu Feb 8 16:49:32 2018 -0500

    Merge pull request #244 from bzwei/v2v_init
    
    Automation for transformation plan
    (cherry picked from commit 684d7b1440dc10e4a0eeb12bdc718f28bf0628a5)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lfu lfu lfu left review comments

@mkanoor mkanoor mkanoor left review comments

@tinaafitz tinaafitz tinaafitz approved these changes

Assignees

@gmcculloug gmcculloug

Labels
enhancement gaprindashvili/backported v2v
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@bzwei @miq-bot @lfu @gmcculloug @billfitzgerald0120 @simaishi @tinaafitz @mkanoor