-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Azure events for targeted refresh #261
Conversation
@lfu Please review |
Checked commit tumido@3b3915c with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 **
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 looks great
@tumido Any reason to keep the |
Just checking if the events get propagated correctly. We have some events which are inconsistent in names e.g.: Does the We can't have multiple files for the same event, which differs in case-sensitive matching, however downcased are the same. (I know this is our mess and we have to clean it, but we can't do so at this point... Because: reasons, lol.) |
This is actually Azure's mess, they don't keep consistent resource type across events (event though it's documented correctly). But I am almost sure we pick the handle by the down-cased string, right @gmcculloug @lfu ? |
So, I've experimentally confirmed, the events are picked up correctly and the refresh lands fine in the @miq-bot remove_label wip |
@tumido Thanks for testing that out. |
@miq-bot add_label gaprindashvili/yes |
Add Azure events for targeted refresh (cherry picked from commit af63ed2) https://bugzilla.redhat.com/show_bug.cgi?id=1558078
Gaprindashvili backport details:
|
Provide automated refresh on events which are recognized by
event_target_parser
in Azure.Related to: ManageIQ/manageiq-providers-azure#222
Part of fix for https://bugzilla.redhat.com/show_bug.cgi?id=1487602