Updated Configuration/Email class and existing V2v instances. #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billfitzgerald0120
force-pushed
the
email_updated_email_class
branch
from
60e921d
to
c95d031
Compare
|
@tinaafitz Please Review |
mkanoor
reviewed
May 23, 2018
| visibility: | ||
| collect: | ||
| scope: | ||
| description: |
There was a problem hiding this comment.
@billfitzgerald0120
Should we put a description that reads something like
"By default the email is enabled, to disable a specific email set this attribute to false"
There was a problem hiding this comment.
Added description as requested
Modified class schema to take advantage of accessing object information from the Configuration/Email namespace. Modified 7 existing V2v instances to match changes to pass schema. Added description for assertion.
billfitzgerald0120
force-pushed
the
email_updated_email_class
branch
from
c95d031
to
c2caa3b
Compare
|
Checked commit billfitzgerald0120@c2caa3b with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
mkanoor
approved these changes
May 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified class schema to take advantage of accessing object information from the Configuration/Email namespace.
Modified 7 existing V2v instances to use new class changes
and to use the new show_url.