Email instances for Cloud VM provisioning. #302
Conversation
|
@miq-bot add_label enhancement |
| end | ||
|
|
||
| def time | ||
| @time = Time.zone.now.strftime('%A, %B %d, %Y at %I:%M%p').to_s |
There was a problem hiding this comment.
@time ||= Time.zone.now.strftime('%A, %B %d, %Y at %I:%M%p').to_s
| @vm_href ||= vm.show_url | ||
| end | ||
|
|
||
| def appliance |
There was a problem hiding this comment.
@billfitzgerald0120
We dont need appliance any more since we are using the show_url, we should delete this function and references to it
|
|
||
| def main | ||
| @handle.log("info", "Starting miq_provision_complete") | ||
| check_email |
There was a problem hiding this comment.
@billfitzgerald0120
This method is only setting the body so should we just change the check_email method to be called
build_body
| body(vm, appliance, prov, vm_href, time) | ||
| end | ||
|
|
||
| def body(vm, _appliance, _prov, _vm_href, _time) |
There was a problem hiding this comment.
billfitzgerald0120
force-pushed
the
email2_cloud_miqprovision
branch
from
2c022d2
to
12b39df
Compare
| @@ -11,12 +11,53 @@ object: | |||
| visibility: | |||
| owner: | |||
| schema: | |||
| - field: | |||
There was a problem hiding this comment.
@billfitzgerald0120
Isn't this change already in master?
billfitzgerald0120
force-pushed
the
email2_cloud_miqprovision
branch
4 times, most recently
from
6854879
to
1c3a9e7
Compare
Added 7 instances in System/Notification/Email class for Cloud/VM provisioning. Modified EmailOwner value in State Machine schema and clone_to_vm instance to use new instances. Modified 3 System/Policy instances to use new email instances. MIqProvisionRequest_Approved MIqProvisionRequest_pending MIqProvisionRequest_denied Created miq_provision_customize_body method. Created test for method. Removed extra space and deleted quotes in body Deleted extra class instance
billfitzgerald0120
force-pushed
the
email2_cloud_miqprovision
branch
from
1c3a9e7
to
1e2f18c
Compare
|
Checked commit billfitzgerald0120@1e2f18c with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@mkanoor I removed the extra spaces, removed the single quotes and deleted the class change. The coverage is still not working properly |
Added 7 instances in System/Notification/Email class for Cloud/VM provisioning.
Modified EmailOwner value in State Machine schema and clone_to_vm instance to
use new instances.
Modified 3 System/Policy instances to use new email instances.
MIqProvisionRequest_Approved
MIqProvisionRequest_pending
MIqProvisionRequest_denied
Created miq_provision_customize_body method.
Created test for method.
https://bugzilla.redhat.com/show_bug.cgi?id=1314871
https://www.pivotaltracker.com/epic/show/3861726