Email instances for VmMigrate and Reconfiguration. #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label enhancement |
|
@tinaafitz @mkanoor Please review |
mkanoor
reviewed
Jun 4, 2018
| @@ -178,7 +178,7 @@ object: | |||
| datatype: string | |||
| priority: 9 | |||
| owner: | |||
| default_value: "/Infrastructure/VM/Migrate/Email/VmMigrateTask_Complete?event=vm_migrated" | |||
| default_value: "/System/Notification/Email/CloudOrchestrationServiceReconfigureComplete?event=service_reconfigured" | |||
There was a problem hiding this comment.
@billfitzgerald0120
Is this value correct, isn't it supposed to be for VmMigrateTask instead of CloudOrchestration
There was a problem hiding this comment.
@mkanoor Yes, I need to fix this
Added 7 instances in System/Notification/Email class for VmMigrate and Reconfiguration. Modified EmailOwner value in 2 State Machine classes to use new instances. Modified 2 System/Request instances to use new instances. Fixed VmMigrate System/Request value.
billfitzgerald0120
force-pushed
the
email3_reconfig_n_migrate
branch
from
91995d8
to
0921fda
Compare
|
Checked commit billfitzgerald0120@0921fda with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@mkanoor Fixed instance, please review |
mkanoor
approved these changes
Jun 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added 7 instances in System/Notification/Email class for VmMigrate and Reconfiguration.
Modified EmailOwner value in 2 State Machine classes to use new instances.
Modified 2 System/Request instances to use new instances.
https://bugzilla.redhat.com/show_bug.cgi?id=1314871
https://www.pivotaltracker.com/epic/show/3861726