Add support for MAC address in network mapping #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
|
@miq-bot add-label enhancement |
|
@miq-bot add-label transformation |
|
@fdupont-redhat To avoid creating technical debt we need to ensure that these PRs include tests. Please reach out to us if you feel you need any help with testing. |
mkanoor
reviewed
Jul 5, 2018
| end | ||
|
|
||
| def storage_mappings(task, vm) | ||
| vm.hardware.disks.select { |d| d.device_type == 'disk' }.each do |disk| |
There was a problem hiding this comment.
@fdupont-redhat
Either you can replace the each with collect and remove the appending into virtv2v_disks or initialize virtv2v_disks array like you do for mapping
def storage_mappings(task, vm)
vm.hardware.disks.select { |d| d.device_type == 'disk' }.collect do |disk|
source_storage = disk.storage
destination_storage = task.transformation_destination(disk.storage)
raise "[#{vm.name}] Disk #{disk.device_name} [#{source_storage.name}] has no mapping. Aborting." if destination_storage.nil?
{
:path => disk.filename,
:size => disk.size,
:percent => 0,
:weight => disk.size.to_f / vm.allocated_disk_storage.to_f * 100
}
end
end
|
Checked commits fabiendupont/manageiq-content@2109027~...62aea5e with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@miq-bot add-label gaprindashvili/yes |
syncrou
suggested changes
Jul 13, 2018
|
Adding specs for v2v methods is being tracked in #360 |
ghost
deleted the
simaishi
pushed a commit
that referenced
this pull request
Jul 31, 2018
…ddress_in_network_mapping Add support for MAC address in network mapping (cherry picked from commit a740e88) https://bugzilla.redhat.com/show_bug.cgi?id=1610547
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the automate side to enable support for Distributed Virtual Switch (DVS) and Distributed Port Group (DPG). The solution is to allow mapping based on the MAC address rather than the source network name. Richard W.M. Jones has implemented the
--macoption in virt-v2v [1]. I have created a PR to add the support for this option in virt-v2v-wrapper [2]. This code simply adds the MAC address of the NICs to the network mappings hash, so that it is passed to virt-v2v-wrapper.Associated RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1594515
[1] https://www.redhat.com/archives/libguestfs/2018-July/msg00004.html
[2] oVirt/v2v-conversion-host#6