Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually rename AE Instances, not just fixture filename #365

Merged
merged 1 commit into from
Jul 19, 2018

Conversation

miha-plesko
Copy link
Contributor

@miha-plesko miha-plesko commented Jul 19, 2018

With previouse commit we accidently only updated filenames leaving actual AE Instance names without the nuage_ prefix. Fixed.

Followup for: #363
RFE BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1574940

@miq-bot add_label enhancement
@miq-bot assign @gmcculloug

/cc @agrare @Ladas

With previouse commit we accidently only updated filenames leaving
actual AE Intance names without the `nuage_` prefix. Fixed.

Signed-off-by: Miha Pleško <miha.plesko@xlab.si>
@miha-plesko
Copy link
Contributor Author

Guys sorry, I should have double checked in first place. Today I tested on fresh database and noticed nuage_ prefix is still missing.

@miq-bot
Copy link
Member

miq-bot commented Jul 19, 2018

Checked commit miha-plesko@0035d31 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🏆

Copy link
Contributor

@Ladas Ladas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gmcculloug gmcculloug merged commit e3960d8 into ManageIQ:master Jul 19, 2018
@gmcculloug gmcculloug added this to the Sprint 91 Ending Jul 30, 2018 milestone Jul 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants