Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor set retry for pre/post migration playbooks #369

Merged
merged 2 commits into from
Jul 24, 2018

Conversation

ghost
Copy link

@ghost ghost commented Jul 23, 2018

As suggested by @mkanoor in another PR, this one separates the retry logic from the main code for pre-post-migration playbooks.

Associated RHBZ:
https://bugzilla.redhat.com/show_bug.cgi?id=1564250

@ghost
Copy link
Author

ghost commented Jul 23, 2018

@miq-bot add-label transformation
@miq-bot add-label enhancement

@miq-bot
Copy link
Member

miq-bot commented Jul 24, 2018

Checked commits fabiendupont/manageiq-content@8d57719~...cf6ba47 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🍪

@ghost
Copy link
Author

ghost commented Jul 24, 2018

@miq-bot add-label gaprindashvili/yes
@miq-bot add-label blocker

@gmcculloug gmcculloug merged commit ac447a3 into ManageIQ:master Jul 24, 2018
@gmcculloug gmcculloug added this to the Sprint 91 Ending Jul 30, 2018 milestone Jul 24, 2018
simaishi pushed a commit that referenced this pull request Jul 25, 2018
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit f4346907b20e99680c010b4e595581fcedff4c3f
Author: Greg McCullough <gmccullo@redhat.com>
Date:   Tue Jul 24 11:18:47 2018 -0400

    Merge pull request #369 from fdupont-redhat/v2v_fix_retry_for_playbook
    
    Refactor set retry for pre/post migration playbooks
    (cherry picked from commit ac447a3e4bfb96f3a283be8d37815bc567f1241b)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1608420

@ghost ghost deleted the v2v_fix_retry_for_playbook branch July 31, 2018 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants