Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hook string passing for pre/post-migration playbooks #370

Merged

Conversation

ghost
Copy link

@ghost ghost commented Jul 24, 2018

The transformation hook is not passed from the parent state machine, so we have to force it. Somehow it was missing in #355.

Associated RHBZ:
https://bugzilla.redhat.com/show_bug.cgi?id=1564250

@ghost
Copy link
Author

ghost commented Jul 24, 2018

@miq-bot add-label transformation
@miq-bot add-label bug
@miq-bot add-label gaprindashvili/yes
@miq-bot add-label blocker

@miq-bot
Copy link
Member

miq-bot commented Jul 24, 2018

Checked commit fabiendupont@aa93f27 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 👍

@gmcculloug gmcculloug self-assigned this Jul 24, 2018
@gmcculloug gmcculloug requested a review from mkanoor July 24, 2018 12:28
@gmcculloug gmcculloug merged commit 54eb45d into ManageIQ:master Jul 24, 2018
@gmcculloug gmcculloug added this to the Sprint 91 Ending Jul 30, 2018 milestone Jul 24, 2018
simaishi pushed a commit that referenced this pull request Jul 25, 2018
…sing

Fix hook string passing for pre/post-migration playbooks
(cherry picked from commit 54eb45d)

https://bugzilla.redhat.com/show_bug.cgi?id=1608420
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 2b6c11eabcf96f51fce80ab11e9c3b20de0629f2
Author: Greg McCullough <gmccullo@redhat.com>
Date:   Tue Jul 24 11:45:24 2018 -0400

    Merge pull request #370 from fdupont-redhat/v2v_fix_playbook_hook_passing
    
    Fix hook string passing for pre/post-migration playbooks
    (cherry picked from commit 54eb45d355954d6c9e7932d092586ea12a46e286)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1608420


@ghost ghost deleted the v2v_fix_playbook_hook_passing branch July 31, 2018 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants