Add default cleanup state machine for VM transformation #378
Conversation
ghost
force-pushed
the
v2v_cleanup_add_default_state_machine
branch
from
1ecbebb
to
bbfc783
Compare
| raise 'No task found. Exiting' if task.nil? | ||
| @handle.log(:info, "Task: #{task.inspect}") if @debug | ||
|
|
||
| destination_ems = @handle.vmdb(:ext_management_system).find_by(:id => task.get_option(:destination_ems_id)) |
There was a problem hiding this comment.
@fdupont-redhat
Can you check if the destination_ems is present before setting the state var.
| destination_vm = @handle.vmdb(:vm).find_by(:id => task.get_option(:destination_vm_id)) | ||
| destination_vm.start | ||
| if @handle.root['service_template_transformation_plan_task'].blank? | ||
| task = @handle.vmdb(:service_template_transformation_plan_task).find_by(:id => @handle.root['service_template_transformation_plan_task_id']) |
There was a problem hiding this comment.
@fdupont-redhat Check for task being nil
There was a problem hiding this comment.
I check if task is nil, as well as VM.
| # Retrieve transformation host | ||
| transformation_host = @handle.vmdb(:host).find_by(:id => task.get_option(:transformation_host_id)) | ||
|
|
||
| # Skip if virtv2v has not started yet or is already finished |
There was a problem hiding this comment.
@fdupont-redhat
Can all of these skips be in a separate function called validate or valid and you call the remote command only if its valid.
| def main | ||
| task = @handle.vmdb(:service_template_transformation_plan_task).find_by(:id => @handle.root['service_template_transformation_plan_task_id']) | ||
| raise 'No task found. Exiting' if task.nil? | ||
| @handle.log(:info, "Task: #{task.inspect}") if @debug |
There was a problem hiding this comment.
@debug is referenced here but never defined.
There was a problem hiding this comment.
Fixed with default value to false.
| module Common | ||
| class VMCheckTransformed | ||
| def initialize(handle = $evm) | ||
| @debug = true |
There was a problem hiding this comment.
and @debug is referenced here but never used.
|
Checked commits fabiendupont/manageiq-content@bbfc783~...01b9fa9 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 content/automate/ManageIQ/Transformation/Common.class/methods/assesstransformationcleanup.rb
content/automate/ManageIQ/Transformation/TransformationHosts/Common.class/methods/killvirtv2v.rb
|
ghost
mentioned this pull request
…tate_machine Add default cleanup state machine for VM transformation (cherry picked from commit fe3fe98) https://bugzilla.redhat.com/show_bug.cgi?id=1608758
|
Gaprindashvili backport details: |
This PR provides the default state machine for VM transformation cleanup. The state machine is triggered from an automate request, as designed in #357. The request creation passes a variable in
$evm.root:service_template_transformation_plan_task_id.The process is as follow:
virt-v2v-wrapperhandles cleaning up the destination provider when the virt-v2v command fails, so nothing to do on ManageIQ side.Associated RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1599997