Transformation - Fix virt-v2v success check #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add-labels transformation, gaprindashvili/yes, bug, blocker |
|
Checked commit fabiendupont@8412315 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
mkanoor
approved these changes
Aug 3, 2018
simaishi
pushed a commit
that referenced
this pull request
Aug 6, 2018
…heck Transformation - Fix virt-v2v success check (cherry picked from commit 6d3d0a3) https://bugzilla.redhat.com/show_bug.cgi?id=1610055
|
Gaprindashvili backport details: |
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current approach checks the
return_codeattribute of the virt-v2v-wrapper state file. However, if the wrapper failed to launch virt-v2v, there no return code. Nonetheless, thefailedattribute is a boolean that we can use to properly raise the exception. This PR implements this new method.Associated RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1564251