Remove check on number of runners when converting VM #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add-labels transformation, bug, gaprindashvili/yes, blocker |
ghost
changed the title
gmcculloug
reviewed
Aug 9, 2018
| ManageIQ::Automate::Transformation::TransformationHost::Common::VMTransform.new.main | ||
| if == __FILE__ | ||
| ManageIQ::Automate::Transformation::TransformationHost::Common::VMTransform.new.main | ||
| end |
There was a problem hiding this comment.
@fdupont-redhat Please follow the changes from #390. You no longer need the if-block here.
mkanoor
reviewed
Aug 9, 2018
| result = Transformation::TransformationHosts::Common::Utils.remote_command(task, transformation_host, "/usr/bin/virt-v2v-wrapper.py", wrapper_options.to_json) | ||
| raise result[:stderr] unless result[:rc].zero? | ||
| @handle.log(:info, "Connecting to #{transformation_host.name} as #{transformation_host.authentication_userid}") if @debug | ||
| @handle.log(:info, "Executing '/usr/bin/virt-v2v-wrapper.py'") |
There was a problem hiding this comment.
@fdupont-redhat
Do we have roles enabled for these tasks to be reliably run on a server where the code exists?
There was a problem hiding this comment.
Yes, the role is enabled as we filter out the hosts in AcquireTransformationHost.
|
Checked commits fabiendupont/manageiq-content@be2da65~...8310264 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
mkanoor
approved these changes
Aug 9, 2018
simaishi
pushed a commit
that referenced
this pull request
Aug 13, 2018
Remove check on number of runners when converting VM (cherry picked from commit 7a0d04d) https://bugzilla.redhat.com/show_bug.cgi?id=1610550
|
Gaprindashvili backport details: |
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When launching the conversion of the VM with virt-v2v, we check that the number of runners is not above the max number of runners per provider. However this check has already been done when acquiring the conversion host, and it leads to pausing the last tasks (number defined by number of generic workers).
This PR removes this check, allowing the balancing to fill the pool of conversions.
Associated RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1600152