Added Quota calculations for reconfigure resize disks #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billfitzgerald0120
force-pushed
the
requested_disk_resize
branch
from
d3ba760
to
876dd4f
Compare
|
@tinaafitz Please Review |
billfitzgerald0120
force-pushed
the
requested_disk_resize
branch
from
876dd4f
to
23b9a5f
Compare
tinaafitz
approved these changes
Oct 22, 2018
mkanoor
reviewed
Oct 22, 2018
| @@ -146,6 +146,11 @@ def vmdb_object(model, id) | |||
| $evm.vmdb(model, id.to_i) if model && id | |||
| end | |||
|
|
|||
| def get_disk_size(disk_name) | |||
| mydisk = $evm.vmdb('disk').find_by(:filename => disk_name) | |||
There was a problem hiding this comment.
@billfitzgerald0120
Should we log disk_names that are not found and raise an error?
Also add a test case where the disk_name doesn't exist.
There was a problem hiding this comment.
@mkanoor Made changes as requested.
billfitzgerald0120
force-pushed
the
requested_disk_resize
branch
from
23b9a5f
to
7513329
Compare
billfitzgerald0120
force-pushed
the
requested_disk_resize
branch
from
7513329
to
d202764
Compare
|
@tinaafitz please review |
billfitzgerald0120
force-pushed
the
requested_disk_resize
branch
from
d202764
to
ab8585d
Compare
mkanoor
reviewed
Nov 27, 2018
| @@ -146,6 +146,12 @@ def vmdb_object(model, id) | |||
| $evm.vmdb(model, id.to_i) if model && id | |||
| end | |||
|
|
|||
| def get_disk_size(disk_name) | |||
| mydisk = $evm.vmdb('disk').find_by(:filename => disk_name) | |||
| raise "ERROR - Disk_name not found for Reconfiguration" if mydisk.nil? | |||
There was a problem hiding this comment.
@billfitzgerald0120 Should we include the disk name when we raise the exception
raise "ERROR - #{disk_name} not found for reconfiguration" if mydisk.nil?
There was a problem hiding this comment.
@mkanoor Included the disk name when we raise the exception, Please review
billfitzgerald0120
force-pushed
the
requested_disk_resize
branch
from
ab8585d
to
2369791
Compare
Added test for disk_resize Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1533263 Made 2 changes as requested Added log_and_raise for disk_names that are not found. Added a test case where the disk_name doesn't exist Modified error text to be generic Removed embedded method Included the disk name when we raise the exception
billfitzgerald0120
force-pushed
the
requested_disk_resize
branch
from
2369791
to
0031d91
Compare
|
Checked commit billfitzgerald0120@0031d91 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
mkanoor
approved these changes
Dec 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added test for disk_resize
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1533263
@miq-bot add_reviewer @tinaafitz
@miq-bot add_label enhancement