Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix request denial #471

Merged
merged 2 commits into from
Nov 13, 2018
Merged

Fix request denial #471

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f3af74a
Fix request denial
fabiendupont Nov 13, 2018
1c6b40c
Fix method name for deny_request
fabiendupont Nov 13, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...rmation/StateMachines/TransformationPlanRequestApproval.class/__methods__/deny_request.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
message = $evm.object['reason']
$evm.log('info', "Request denied because of #{message}")
request.message = message
request.deny('admin', msg = message)
request.deny('admin', message)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fdupont-redhat I do not see how this would do anything more than assign an unused variable msg. The result of the assignment msg = message would return the content of the message variable and passed that as the second parameter to the deny method.

While this is a reasonable cleanup I am concerned that this is not actually fixing any bug.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gmcculloug You're completely right. Going too fast. The problem is more likely the name of the method in deny_request.yml... Fixed in my appliance in an overlay domain, but not in ManageIQ. My bad.

2 changes: 1 addition & 1 deletion ...ation/StateMachines/TransformationPlanRequestApproval.class/__methods__/deny_request.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ object_type: method
version: 1.0
object:
attributes:
name: pending_request
name: deny_request
display_name:
description:
scope: instance
Expand Down