Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TransformationPlanRequest approval - Set message #473

Merged
merged 1 commit into from
Nov 15, 2018

Conversation

ghost
Copy link

@ghost ghost commented Nov 15, 2018

deny_request and validate_request were using request.message= which doesn't exist. This PR makes them use request.set_message() instead.

Associated RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1640816

@ghost
Copy link
Author

ghost commented Nov 15, 2018

@miq-bot add-label transformation, bug, hammer/yes, blocker

@miq-bot
Copy link
Member

miq-bot commented Nov 15, 2018

Checked commit fabiendupont@27c98b6 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 🍰

@coveralls
Copy link

coveralls commented Nov 15, 2018

Pull Request Test Coverage Report for Build 2351

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.273%

Totals Coverage Status
Change from base Build 2347: 0.0%
Covered Lines: 2925
Relevant Lines: 3007

💛 - Coveralls

@gmcculloug gmcculloug self-assigned this Nov 15, 2018
@gmcculloug gmcculloug merged commit ec23af9 into ManageIQ:master Nov 15, 2018
@gmcculloug gmcculloug added this to the Sprint 99 Ending Nov 19, 2018 milestone Nov 15, 2018
simaishi pushed a commit that referenced this pull request Nov 16, 2018
Fix TransformationPlanRequest approval - Set message

(cherry picked from commit ec23af9)

https://bugzilla.redhat.com/show_bug.cgi?id=1640816
@simaishi
Copy link
Contributor

Hammer backport details:

$ git log -1
commit 83484b049ae61ab722bb50145ea509481e9b82e3
Author: Greg McCullough <gmccullo@redhat.com>
Date:   Thu Nov 15 17:19:12 2018 -0500

    Merge pull request #473 from fdupont-redhat/v2v_fix_approval
    
    Fix TransformationPlanRequest approval - Set message
    
    (cherry picked from commit ec23af9745835f38507734744ba90011d32038ac)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1640816

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants