[V2V] Remove check on power_off variable #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label transformation, bug, hammer/yes |
|
@fdupont-redhat 'jameswnl' is an invalid reviewer, ignoring... |
Pull Request Test Coverage Report for Build 2818
💛 - Coveralls |
|
Checked commit fabiendupont@1f4c62b with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
jameswnl
approved these changes
Mar 14, 2019
|
@miq-bot add_label blocker |
simaishi
pushed a commit
that referenced
this pull request
Mar 18, 2019
…off_variable [V2V] Remove check on power_off variable (cherry picked from commit 71fb5b8) https://bugzilla.redhat.com/show_bug.cgi?id=1689947
|
Hammer backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we designed the migration workflow, we didn't want to force the shutdown of the VM. We wanted to have an explicit sign-off. So, we implemented a check on a
power_offboolean variable. This variable was set totruein the first state of the state machine. The associated UI was never implemented and we always shutdown the VMs.When the throttling code was moved to the backend, the variable was not set anymore, so all migrations fail. As it's not used, removing the check on
power_offvariable is cleaner.Associated RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1688465