VM Retirement Request - clear values from vmretire_request_starting instance. #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With retirement as a request, retirement is initiated when the tasks are created. We need to clear the values of this instance because the request task processing will create the request tasks only if the request_starting event succeeds.
|
@miq-bot add_label bug, hammer/yes |
|
Checked commit tinaafitz@c714094 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
Pull Request Test Coverage Report for Build 3038
💛 - Coveralls |
mkanoor
approved these changes
May 7, 2019
simaishi
pushed a commit
that referenced
this pull request
May 7, 2019
…instance VM Retirement Request - clear values from vmretire_request_starting instance. (cherry picked from commit a2eb75a) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1707456
|
Hammer backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This instance used to call into automate to initiate retirement.
With retirement as a request, retirement is initiated when the tasks are
created. We need to clear the values of this instance because the
request task processing will create the request tasks only if the
request_starting event succeeds.
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1706208
Also requires: ManageIQ/manageiq#18738