Fix check_reconfigured ae_result to prevent retry loop and failure. #548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 3297
💛 - Coveralls |
tinaafitz
force-pushed
the
fix_reconfigure
branch
2 times, most recently
from
23edc94
to
d1f803b
Compare
refresh_may_have_completed is true. The update_result and update_reason state_vars contained the previous values. The state_var update_result value was still set to retry from the previous execution which caused the state machine to retry instead of proceeding to the next state. It had another side affect in that the retry was set with no retry interval which caused the state machine to retry immediately instead of waiting the usual time interval. Resetting those values caused the state machine to progress to the next state and complete successfully. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1720212
tinaafitz
force-pushed
the
fix_reconfigure
branch
from
d1f803b
to
737b093
Compare
|
Checked commit tinaafitz@737b093 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
|
👍 |
|
looks good |
lfu
approved these changes
Jul 8, 2019
d-m-u
approved these changes
Jul 8, 2019
|
@tinaafitz |
simaishi
pushed a commit
that referenced
this pull request
Jul 8, 2019
Fix check_reconfigured ae_result to prevent retry loop and failure. (cherry picked from commit 84d55fe) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1727970
|
Hammer backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reset ae_reason and ae_result in check_refreshed when refresh_may_have_completed is true.
The update_result and update_reason state_vars contained the
previous values. The state_var update_result
value was still set to retry from the previous execution which caused
the state machine to retry instead of proceeding to the next state.
It had an additional side affect in that the retry was set with no retry
interval which caused the state machine to retry immediately instead of
waiting the usual 1 minute time interval.
Resetting those values enabled the state machine to progress to the next
state and complete successfully.
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1720212