Disabled DeleteFromVMDB in 2 places. #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified StackRetirement Schema and Infrastructure/VM/Retirement unregister instance. DeleteFromVMDB is disabled everywhere else as per PM.
|
@tinaafitz |
|
@billfitzgerald0120 @tinaafitz Is there a BZ you can associate to this? |
gmcculloug
changed the title
|
@tinaafitz |
billfitzgerald0120
changed the title
tinaafitz
reviewed
Feb 23, 2017
| @@ -3,7 +3,7 @@ object_type: instance | |||
| version: 1.0 | |||
| object: | |||
| attributes: | |||
| display_name: Unregister | |||
| display_name: | |||
| name: Unregister | |||
| inherits: | |||
| description: | |||
There was a problem hiding this comment.
@billfitzgerald0120 Can you comment out the DeleteFromVMDB call here?
There was a problem hiding this comment.
I commented it out ...
|
@tinaafitz |
|
Checked commits billfitzgerald0120/manageiq-content@cc12cfe~...08ae795 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@billfitzgerald0120 Looks good. |
mkanoor
approved these changes
Mar 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.redhat.com/show_bug.cgi?id=1425206
Modified StackRetirement Schema and Infrastructure/VM/Retirement unregister instance.
DeleteFromVMDB is disabled everywhere else.