Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

manageiq-core.manageiq-automate Wrap all values in quotes #555

Merged
merged 1 commit into from
Aug 2, 2019
Merged

manageiq-core.manageiq-automate Wrap all values in quotes #555

merged 1 commit into from
Aug 2, 2019

Conversation

syncrou
Copy link
Contributor

@syncrou syncrou commented Aug 2, 2019 •
edited
Loading

Reworks the exists() method to wrap all values in quotes so
the bool() method will not interpret the values as false.

This change brings the shipped role / module in line with release 0.1.1 on Galaxy

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1730311

@syncrou
Wrap all values in quotes
461464e 
Reworks the exists() method to wrap all values in quotes so
the bool() method will not interpret the values as false
@syncrou syncrou changed the title Wrap all values in quotes manageiq-core.manageiq-automate Wrap all values in quotes Aug 2, 2019
@syncrou
Copy link
Contributor Author

syncrou commented Aug 2, 2019

@miq-bot assign @tinaafitz

@syncrou
Copy link
Contributor Author

syncrou commented Aug 2, 2019

@miq-bot add_label bug

@miq-bot miq-bot added the bug label Aug 2, 2019
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3391

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 96.936%
Totals Coverage Status
Change from base Build 3383: 0.01%
Covered Lines: 2911
Relevant Lines: 3003
💛 - Coveralls

@miq-bot
Copy link
Member

miq-bot commented Aug 2, 2019

Checked commit syncrou@461464e with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🍪

@tinaafitz tinaafitz merged commit f0bf90e into ManageIQ:master Aug 2, 2019
@simaishi
Copy link
Contributor

simaishi commented Aug 5, 2019

@syncrou ivanchuk/yes?

@syncrou
Copy link
Contributor Author

syncrou commented Aug 5, 2019

@simaishi Not sure. @tinaafitz Do you have insight into this question?

@tinaafitz
Copy link
Member

@syncrou @simaishi Yes for ivanchuk/yes

simaishi pushed a commit that referenced this pull request Aug 6, 2019
@tinaafitz @simaishi
Merge pull request #555 from syncrou/wrap_all_values_in_quotes
959321e 
manageiq-core.manageiq-automate Wrap all values in quotes

(cherry picked from commit f0bf90e)

https://bugzilla.redhat.com/show_bug.cgi?id=1730311
@simaishi
Copy link
Contributor

simaishi commented Aug 6, 2019

Ivanchuk backport details:

$ git log -1
commit 959321e68f078a91315385acdd25a5d9aea5adb0
Author: tina <tfitzger@redhat.com>
Date:   Fri Aug 2 16:18:42 2019 -0400

    Merge pull request #555 from syncrou/wrap_all_values_in_quotes
    
    manageiq-core.manageiq-automate Wrap all values in quotes
    
    (cherry picked from commit f0bf90e63d9baa19c9392995b73b99cd0223f0cd)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1730311

@gmcculloug gmcculloug added this to the Sprint 117 Ending Aug 5, 2019 milestone Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tinaafitz tinaafitz tinaafitz approved these changes

Assignees

@tinaafitz tinaafitz

Labels
bug ivanchuk/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@syncrou @coveralls @miq-bot @simaishi @tinaafitz @gmcculloug