Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[V2V] Remove CollapseSnapshots state and methods #566

Merged
merged 1 commit into from Aug 29, 2019
Merged

[V2V] Remove CollapseSnapshots state and methods #566

merged 1 commit into from Aug 29, 2019

Conversation

ghost
Copy link

@ghost ghost commented Aug 24, 2019

The state machine is being ported to InfraConversionJob.
This PR is the counterpart of ManageIQ/manageiq#19177.

RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1740881
Depends on ManageIQ/manageiq#19177

@ghost
Copy link
Author

ghost commented Aug 24, 2019

@miq-bot add-label transformation, refactoring, ivanchuk/yes
@miq-bot add-reviewer @gmcculloug

@coveralls
Copy link

coveralls commented Aug 24, 2019 •
edited

Pull Request Test Coverage Report for Build 3493

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.004%) to 96.905%
Totals Coverage Status
Change from base Build 3484: 0.004%
Covered Lines: 2943
Relevant Lines: 3037
💛 - Coveralls

@miq-bot
Copy link
Member

miq-bot commented Aug 24, 2019

Checked commit fabiendupont@83796ef with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🍰

@ghost ghost mentioned this pull request Aug 26, 2019
Merged
@ghost
Copy link
Author

ghost commented Aug 26, 2019

@miq-bot add-reviewer @tinaafitz

@miq-bot miq-bot requested a review from tinaafitz August 26, 2019 06:12
@djberg96
Copy link
Contributor

👍

gmcculloug
gmcculloug approved these changes Aug 26, 2019
View reviewed changes
Copy link
Member

@gmcculloug gmcculloug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fdupont-redhat Looks good. Let me know when the dependent PR is merged.

@gmcculloug gmcculloug self-assigned this Aug 26, 2019
@ghost
Copy link
Author

ghost commented Aug 27, 2019

@gmcculloug the dependent PR is merged. Thanks.

@gmcculloug gmcculloug merged commit 2e96f80 into ManageIQ:master Aug 29, 2019
@gmcculloug gmcculloug added this to the Sprint 119 Ending Sep 2, 2019 milestone Aug 29, 2019
simaishi pushed a commit that referenced this pull request Oct 31, 2019
@gmcculloug @simaishi
Merge pull request #566 from fdupont-redhat/v2v_state_machine_remove_…
f8d1c45 
…collapse_snapshots

[V2V] Remove CollapseSnapshots state and methods

(cherry picked from commit 2e96f80)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1767543
@simaishi
Copy link
Contributor

Ivanchuk backport details:

$ git log -1
commit f8d1c45aff1132f2b10daa7b84c9afe802001c22
Author: Greg McCullough <gmccullo@redhat.com>
Date:   Thu Aug 29 07:02:14 2019 -0400

    Merge pull request #566 from fdupont-redhat/v2v_state_machine_remove_collapse_snapshots
    
    [V2V] Remove CollapseSnapshots state and methods
    
    (cherry picked from commit 2e96f80c70aecb5f9f85d39a04f74ff59acd4860)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1767543

simaishi added a commit that referenced this pull request Dec 3, 2019
@simaishi
Revert "Merge pull request #566 from fdupont-redhat/v2v_state_machine…
ef852ca 
…_remove_collapse_snapshots"

This reverts commit f8d1c45.

https://bugzilla.redhat.com/show_bug.cgi?id=1767543
@simaishi
Copy link
Contributor

simaishi commented Dec 3, 2019

The backport reverted

commit ef852cadf851d2835424c46ccf8db2fef62e2074
Author: Satoe Imaishi <simaishi@redhat.com>
Date:   Tue Dec 3 11:13:32 2019 -0500

    Revert "Merge pull request #566 from fdupont-redhat/v2v_state_machine_remove_collapse_snapshots"

    This reverts commit f8d1c45aff1132f2b10daa7b84c9afe802001c22.

    https://bugzilla.redhat.com/show_bug.cgi?id=1767543

simaishi pushed a commit that referenced this pull request Feb 21, 2020
@gmcculloug @simaishi
Merge pull request #566 from fdupont-redhat/v2v_state_machine_remove_…
702e072 
…collapse_snapshots

[V2V] Remove CollapseSnapshots state and methods

(cherry picked from commit 2e96f80)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1767543
@simaishi
Copy link
Contributor

Ivanchuk backport details:

$ git log -1
commit 702e072fccbbb44ae6d6c0de1254bf62a6f3bc4a
Author: Greg McCullough <gmccullo@redhat.com>
Date:   Thu Aug 29 07:02:14 2019 -0400

    Merge pull request #566 from fdupont-redhat/v2v_state_machine_remove_collapse_snapshots

    [V2V] Remove CollapseSnapshots state and methods

    (cherry picked from commit 2e96f80c70aecb5f9f85d39a04f74ff59acd4860)

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1767543

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tinaafitz tinaafitz Awaiting requested review from tinaafitz

Assignees

@gmcculloug gmcculloug

Labels
changelog/yes ivanchuk/backported refactoring v2v
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@coveralls @miq-bot @djberg96 @simaishi @gmcculloug @mkanoor @fabiendupont