Allow for nulls in the exists method #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the allow_null argument is true we now allow any result to return as true. This nullifies the bool() check So seems bad, but in some cases when an attribute exists When looking up 'get_object_attribute_names' we want the value of that attribute even if it is null In the case of an allow_null then only a KeyError will return False
|
@miq-bot assign @tinaafitz cc - @mkanoor |
|
@miq-bot add_label bug |
|
Checked commit syncrou@b1e6c8d with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
Pull Request Test Coverage Report for Build 3523
💛 - Coveralls |
mkanoor
approved these changes
Sep 3, 2019
simaishi
pushed a commit
that referenced
this pull request
Sep 3, 2019
Allow for nulls in the exists method (cherry picked from commit 2c6c747) https://bugzilla.redhat.com/show_bug.cgi?id=1730311
|
Ivanchuk backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the allow_null argument is true we now allow any result
to return as true. This nullifies the bool() check
So seems bad, but in some cases when an attribute exists
When looking up 'get_object_attribute_names' we want
the value of that attribute even if it is null
In the case of an allow_null then only a KeyError
will return False
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1730311