Generic Service State Machine methods modified to use Service object. #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
object and pass service_action to retirement.
tinaafitz
force-pushed
the
service_object_changes
branch
from
ed8ed61
to
b394af0
Compare
tinaafitz
changed the title
|
@mkanoor Please review. |
mkanoor
reviewed
Feb 23, 2017
| @@ -20,33 +20,45 @@ def main | |||
|
|
|||
| private | |||
|
|
|||
| def task | |||
| def update_task(message) | |||
| return unless service_action == 'Provision' | |||
There was a problem hiding this comment.
@tinaafitz
Can we not check service_action but rather check if we have a task we update the message else skip over
mkanoor
reviewed
Feb 23, 2017
| @@ -20,33 +20,45 @@ def main | |||
|
|
|||
| private | |||
|
|
|||
| def task | |||
| def update_task(message) | |||
| return unless service_action == 'Provision' | |||
| @handle.root["service_template_provision_task"].tap do |task| | |||
There was a problem hiding this comment.
@tinaafitz Since task is optional could we use try
@handle.root['service_template_provision_task'].try { |task| task.miq_request.user_message = message }
mkanoor
reviewed
Feb 23, 2017
| task.miq_request.user_message = err.message | ||
| @handle.log("info", "Error in execute") | ||
| @handle.log("info", "Error in execute: #{err.message}") | ||
| update_task(err.message) |
There was a problem hiding this comment.
@tinaafitz
Should update_task take a second parameter to indicate if its info or error?
There was a problem hiding this comment.
@mkanoor - update_task is called only for errors.
|
@mkanoor Changes made. |
tinaafitz
force-pushed
the
service_object_changes
branch
from
d5cfe34
to
1a0f33f
Compare
|
Checked commits tinaafitz/manageiq-content@7051178~...1a0f33f with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Service object changes