Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add handling vnic events for rhev #582

Merged
merged 1 commit into from Sep 18, 2019
Merged

Add handling vnic events for rhev #582

merged 1 commit into from Sep 18, 2019

Conversation

borod108
Copy link

@miq-bot
Copy link
Member

miq-bot commented Sep 17, 2019

Checked commit borod108@d8004bd with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🍰

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3609

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.001%) to 96.795%
Totals Coverage Status
Change from base Build 3607: -0.001%
Covered Lines: 2748
Relevant Lines: 2839
💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3609

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.001%) to 96.795%
Totals Coverage Status
Change from base Build 3607: -0.001%
Covered Lines: 2748
Relevant Lines: 2839
💛 - Coveralls

@agrare
Copy link
Member

agrare commented Sep 17, 2019

@miq-bot assign @gmcculloug
@miq-bot add-label enhancement

@gmcculloug gmcculloug merged commit e166253 into ManageIQ:master Sep 18, 2019
@gmcculloug gmcculloug added this to the Sprint 121 Ending Sep 30, 2019 milestone Sep 18, 2019
simaishi pushed a commit that referenced this pull request Nov 1, 2019
@gmcculloug @simaishi
Merge pull request #582 from borod108/bug/network_remod
e3366f1 
Add handling vnic events for rhev

(cherry picked from commit e166253)

https://bugzilla.redhat.com/show_bug.cgi?id=1767787
@simaishi
Copy link
Contributor

simaishi commented Nov 1, 2019

Ivanchuk backport details:

$ git log -1
commit e3366f12f02de4ecc85bbac3a1e123c2b32b0f06
Author: Greg McCullough <gmccullo@redhat.com>
Date:   Wed Sep 18 08:12:22 2019 -0400

    Merge pull request #582 from borod108/bug/network_remod
    
    Add handling vnic events for rhev
    
    (cherry picked from commit e1662534fad5168be34f4128010dd9dd49220c23)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1767787

@borod108 borod108 mentioned this pull request Nov 1, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmcculloug gmcculloug gmcculloug approved these changes

@agrare agrare agrare approved these changes

Assignees

@gmcculloug gmcculloug

Labels
enhancement events ivanchuk/backported providers/virtual
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@borod108 @miq-bot @coveralls @agrare @simaishi @gmcculloug