Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing power_off and check_power_off methods in Retirement class. #593

Conversation

billfitzgerald0120
Copy link
Contributor

@billfitzgerald0120 billfitzgerald0120 commented Oct 28, 2019

Class Infrastructure/VM/Retirement Methods have been replaced by pre_retirement and check_pre_retirement.

State Machine is no longer using these methods.

@miq-bot add_label refactoring, test, cleanup
Removed power_off and check_power_off specs.

@coveralls
Copy link

coveralls commented Oct 28, 2019

Pull Request Test Coverage Report for Build 3778

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 96.838%

Totals Coverage Status
Change from base Build 3756: 0.04%
Covered Lines: 8178
Relevant Lines: 8445

💛 - Coveralls

@billfitzgerald0120
Copy link
Contributor Author

@miq-bot remove_label refactoring

… class.

Methods have been replaced by pre_retirement and check_pre_retirement.

State Machine is no longer using these methods.
Removing specs for power_off and check_power_off
@billfitzgerald0120 billfitzgerald0120 force-pushed the remove_infra_vm_retirement_old_methods branch from eb54feb to b08d54a Compare October 29, 2019 20:19
@miq-bot
Copy link
Member

miq-bot commented Oct 29, 2019

Checked commit billfitzgerald0120@b08d54a with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 👍

@tinaafitz tinaafitz added this to the Sprint 124 Ending Nov 11, 2019 milestone Nov 11, 2019
@tinaafitz tinaafitz merged commit 9956939 into ManageIQ:master Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants