Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor delete_from_vmdb method for Infra VM Retirement. #597

Conversation

billfitzgerald0120
Copy link
Contributor

@billfitzgerald0120 billfitzgerald0120 commented Nov 4, 2019

This PR is based on the issue below.
ManageIQ/manageiq#12038

@miq-bot add_label refactoring
@miq-bot assign @tinaafitz

This PR is based on on the issue below.
ManageIQ/manageiq#12038

@miq-bot add_label refactoring
@miq-bot assign @tinaafitz
@coveralls
Copy link

coveralls commented Nov 4, 2019

Pull Request Test Coverage Report for Build 3808

  • 17 of 17 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 96.841%

Totals Coverage Status
Change from base Build 3807: 0.05%
Covered Lines: 2790
Relevant Lines: 2881

💛 - Coveralls

@miq-bot
Copy link
Member

miq-bot commented Nov 4, 2019

Checked commit billfitzgerald0120@7fd39d7 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 👍

@tinaafitz tinaafitz merged commit 7a94511 into ManageIQ:master Nov 11, 2019
@tinaafitz tinaafitz added this to the Sprint 124 Ending Nov 11, 2019 milestone Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants