-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for Quota validation issue with service dialog memory values. #620
Fix for Quota validation issue with service dialog memory values. #620
Conversation
Modified requested method for the following 2 issues: 1. vm_memory value in service dialog was NOT being used for Quota requested. 2. option_0_vm_memory value in service dialog was being used without the megabytes so 8192 would only be 8KB not 8GIG. With this fix, if you use option_0_vm_memory or vm_memory in a service dialog and request 8192, it will be 8 GIG requested in Quota. fixes:https://bugzilla.redhat.com/show_bug.cgi?id=1775211 @miq-bot add_label bug @miq-bot assign @tinaafitz
Checked commit billfitzgerald0120@fcb47cd with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
Pull Request Test Coverage Report for Build 4025
💛 - Coveralls |
@miq-bot add_label hammer/no, ivanchuk/no, changelog/yes |
@billfitzgerald0120 @tinaafitz The BZ is targeted for 5.10.z, but this PR is marked as |
Hi @simaishi @dmetzger57 and I discussed the issue this morning. We're not going to change 5.10. I'm waiting to hear back from Josh to see if we should change 5.11. We're going to create a talk topic that will include instructions for customers to manually apply the code changes in their environment. |
@tinaafitz Thank you for the update! |
I created a talk topic that includes instructions for customers to manually apply the code changes in their environment. http://talk.manageiq.org/t/quota-problems-with-vm-memory-in-a-service-dialog/4748 |
Modified requested method for the following 2 issues:
With this fix, if you use option_0_vm_memory or vm_memory in a service dialog and request 8192, it will be 8 GIG requested in Quota.
fixes:https://bugzilla.redhat.com/show_bug.cgi?id=1775211
@miq-bot add_label bug
@miq-bot assign @tinaafitz