Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving RedHat domain content for Namespace "Integration" to ManageIQ. #622

Merged

Conversation

billfitzgerald0120
Copy link
Contributor

Moving RedHat Automate Namespace "Integration" which includes ServiceNow and VMware components to the ManageIQ domain.

@miq-bot assign @tinaafitz

…ManageIQ.

Namespace "Integration" which includes ServiceNow and VMware components NOT found currently in ManageIQ domain.
@miq-bot
Copy link
Member

miq-bot commented Dec 20, 2019

Checked commit billfitzgerald0120@4498156 with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
9 files checked, 19 offenses detected

content/automate/ManageIQ/Integration/ServiceNow/CMDB.class/methods/create.rb

content/automate/ManageIQ/Integration/ServiceNow/CMDB.class/methods/delete.rb

content/automate/ManageIQ/Integration/ServiceNow/CMDB.class/methods/get.rb

content/automate/ManageIQ/Integration/ServiceNow/CMDB.class/methods/get_all.rb

content/automate/ManageIQ/Integration/ServiceNow/CMDB.class/methods/update.rb

content/automate/ManageIQ/Integration/ServiceNow/CMDB.class/methods/update_patch.rb

@coveralls
Copy link

coveralls commented Dec 20, 2019

Pull Request Test Coverage Report for Build 4033

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.27%

Totals Coverage Status
Change from base Build 4030: 0.0%
Covered Lines: 3028
Relevant Lines: 3113

💛 - Coveralls

@miq-bot
Copy link
Member

miq-bot commented Dec 20, 2019

Some comments on commit billfitzgerald0120@4498156

content/automate/ManageIQ/Integration/ServiceNow/CMDB.class/methods/create.rb

  • 💣 💥 🔥 🚒 - 54 - Detected cloudforms

content/automate/ManageIQ/Integration/ServiceNow/CMDB.class/methods/update.rb

  • 💣 💥 🔥 🚒 - 67 - Detected cloudforms

content/automate/ManageIQ/Integration/ServiceNow/CMDB.class/methods/update_patch.rb

  • 💣 💥 🔥 🚒 - 54 - Detected cloudforms

@billfitzgerald0120 billfitzgerald0120 changed the title [WIP] Moving RedHat domain content for Namespace "Integration" to ManageIQ. Moving RedHat domain content for Namespace "Integration" to ManageIQ. Jan 2, 2020
@miq-bot miq-bot removed the wip label Jan 2, 2020
@lfu
Copy link
Member

lfu commented Jan 3, 2020

Can you add a snapshot of the added namespace/classes? Thanks.

@billfitzgerald0120
Copy link
Contributor Author

Snapshot of the added namespace/classes

Screen Shot 2020-01-03 at 2 15 39 PM

@tinaafitz tinaafitz merged commit 72997ca into ManageIQ:master Jan 6, 2020
@tinaafitz tinaafitz added this to the Sprint 127 Ending Jan 6, 2020 milestone Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants